summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Make rc.packages deal with fcgicli callRenato Botelho2015-06-301-4/+16
|
* Merge pull request #1732 from phil-davis/traffic-graphs-widgetRenato Botelho2015-06-292-4/+19
|\
| * Only process Traffic Graph object if it is openPhil Davis2015-06-262-4/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Traffic Graphs widget puts a graph object for every interface into the HTML of the widget. Underneath the graph object for every interface makes the call to graph.php to get data for the graph, and the refresh interval also keeps happening, which keeps gathering the data every refresh interval for every interface. This wastes a lot of CPU back on the pfSense box gathering data repeatedly if the system has a lot of interfaces and only has the Traffic Graph enabled for 1 or a few of them. e.g. on my poor little Alix at home I had setup 6 VLANs to test some stuff, so I had WAN, LAN, OPT1 and 6 tagged VLANS - 9 interfaces. When I enable the Traffic Graphs widget on the dashboard, the Alix CPU is driven 100% trying to keep up with gathering data for 9 interfaces every 10 seconds, even though I only have 1 graph actually opened! I couldn't see a way to enable/disable the graph.php object from executing. So this change puts the object in and out of the HTML: a) At first display the graph.php object HTML is only put in the relevant "div" if the graph is actually set to be shown in the config. b) When a graph is opened by the user, the Java Script puts the necessary graph.php object HTML into the div. The graph data then starts being requested... c) When a graph is minimised by the user, the Java Script removes the graph.php object HTML from the div. The actions of graph.php stop happening. I can see the difference by just watching "top" from the command line on a low-power system and open/minimizing the graphs on the dashboard. If there is a better way to enable/disable an object like this I am happy to learn about it.
* | Use interface-automatic for Unbound when the interfaces list is empty (same ↵jim-p2015-06-261-0/+2
|/ | | | as All) otherwise it breaks with a default CARP config.
* Merge pull request #1717 from phil-davis/traffic-graph-descriptionRenato Botelho2015-06-252-19/+46
|\
| * Add DNS host override descriptionsPhil Davis2015-06-221-14/+30
| | | | | | | | | | | | | | | | since we can sometimes provide a useful description from that config data also. Fill the $iplookup array with host or FQDN data if description is blank or host or FQDN was requested. Then we can use $iplookup in all cases where we have local data. It simplifies some logic a bit.
| * Add description as a display option on Traffic GraphPhil Davis2015-06-122-16/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is handy at sites where lots of the LAN clients have static-mapped DHCP IP addresses. Depending on the site host naming conventions, host names can be a bit obtuse - may not tell you where the client device might actually be in the building. We put other useful stuff in the description - "Jane Doe - Reception". This enhancement allows the user of Traffic Graph to select "Description" in the "Display" dropdown. Then, for IP addresses that are static mapped, the description from the config is shown, rather than the host name. When a client device is noticed hogging bandwidth, it is easy to go straight to "Jane Doe - Reception" and ask why they are doing some huge download. Might be useful for for others?
* | Merge pull request #1725 from phil-davis/gateways-widgetRenato Botelho2015-06-252-12/+126
|\ \
| * | GW widget input form name-id needs to be uniquePhil Davis2015-06-231-1/+1
| | | | | | | | | | | | | | | among all widget forms. Traffic Graphs widget already uses the vanilla name "iform". Reusing that name causes Traffic Graphs widget graph display state (show/hide) not to be saved if GW widget was also displayed on the dashboard. This fixes it.
| * | Display monitor IP on Gateways widgetPhil Davis2015-06-202-12/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds a setting for the Gateways dashboard widget so the user can choose to display the Gateway IP, Monitor IP or both. If "both" is chosen and the Gateway IP is the Monitor IP, then only the Gateway IP is shown - i.e. the same IP address is not repeated on the widget display. If "both" is chosen and the Monitor IP is different to the Gateway IP then the Monitor IP is shown in () brackets after the Gateway IP. If "Monitor IP" is chosen and there is no special Monitor IP defined, then the Gateway IP is displayed (which is also the Monitor IP). If "Gateway IP" is chosen then the widget behaves as it does now. "Gateway IP" is the default. I find this handy because the Gateways widget reports RTT (latency) and loss figures that are actually for pings to the Monitor IP. So it seems useful to be able to display the Monitor IP in the widget.
* | | Merge pull request #1730 from phil-davis/patch-2Renato Botelho2015-06-251-14/+14
|\ \ \
| * | | Display any advanced DHCP server settingsPhil Davis2015-06-241-14/+14
| | | | | | | | | | | | | | | | | | | | when the page is first displayed. This has annoyed me a few times and it annoyed me again just now. I had some settings in one of the advanced boxes that were no longer wanted, but when the services_dhcp page is shown the contents of advanced settings are not shown to the user - the user has to click on each advanced button to see if there are any settings already there. This change displays the settings automatically, if there is something already specified. It works the same way as the Firewall Rules advanced boxes.
* | | | Merge pull request #1729 from phil-davis/widget-iformRenato Botelho2015-06-257-13/+13
|\ \ \ \
| * | | | Standardize widget iform and submit namesPhil Davis2015-06-237-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The log and picture widgets were both using "iforma" and "submita". Actually it did not break anything because it was only the form name repeated, not id. And nothing was using these names. Traffic Graphs widget was using just "iform". That is a bit dangerous for the future. I got tricked when cut-pasting some code to make some settings options for the Gateways widget. I kept "iform" and then wondered for a while why my Traffic Graphs widget show-hide settings would not save. There was traffic graph JS that referred to just "iform" and that started modifying the "iform" in my new Gateways widget code. Rather than having names "iforma", "iformb"... "submita", "submitb"... it seems much less risk of accidental duplication if these are named like: name_of_widget_iform name_of_widget_submit I don't think there is any user-visible bug in 2.2.* - so this standardization could just go into 2.3
* | | | | Merge pull request #1719 from N0YB/XHTML_Compliance_Diagnostics_TablesRenato Botelho2015-06-251-2/+3
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Add semicolonN0YB2015-06-151-2/+3
| | | | | | | | | | | | | | | | | | | | Fix delete Java Script to match valid HTML ID
| * | | | XHTML ComplianceN0YB2015-06-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | html id's not permitted to begin with a number. html id's not permitted to contain '/' add prefix (entry_) and replace slash with hyphen. table entry id format becomes: entry_<ip address>-<cidr> replacing the format: <ip address>/<cidr> does not change the displayed format.
* | | | | Add D1540-XG.Matt Smith2015-06-231-0/+3
| | | | |
* | | | | Introduce Netgate RCC-DFF to the list of known platformsRenato Botelho2015-06-232-2/+8
| | | | |
* | | | | rereadall is not enough here, restore reload call to make sure everything ↵Renato Botelho2015-06-231-0/+1
| | | | | | | | | | | | | | | | | | | | works. Ticket #4785
* | | | | Replace ipsec rereadsecrets + reload by single rereadall, that will re-read ↵Renato Botelho2015-06-231-2/+1
| | | | | | | | | | | | | | | | | | | | also cert changes. Ticket #4785
* | | | | Instead of sending USR1, just call ipsec reload. And before it, call ipsec ↵Renato Botelho2015-06-231-1/+2
| | | | | | | | | | | | | | | | | | | | rereadsecrets to make sure new secretes are updated. It should fix #4785
* | | | | Partially revert 019ee2bc8c, this workaround is not necessary. Real fix will ↵Renato Botelho2015-06-231-8/+0
| | | | | | | | | | | | | | | | | | | | be committed after this
* | | | | Add a workaround for ticket #4785:Renato Botelho2015-06-231-4/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a regression on strongswan between 5.3.0 and 5.3.2 as reported at [1]. To workaround this issue, add an extra line on ipsec.secrets with right fqdn.
* | | | | Merge pull request #1728 from devnullity/patch-1Chris Buechler2015-06-231-1/+1
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Fix var name typo in shaper.inc Ben Cook2015-06-211-1/+1
| | | | | | | | | | | | | | | Fix typo so get_bandwidthtype_scale can do more than default to "1".
* | | | | Don't delete /var/tmp/, that was originally done to clear session data at ↵Chris Buechler2015-06-221-1/+0
| | | | | | | | | | | | | | | | | | | | boot, but no longer applicable as session data is no longer in /var/tmp/. Credit to 'aa' on opnsense forum.
* | | | | Use $myid in ipsec.secrets. Ticket #4785Chris Buechler2015-06-221-2/+2
|/ / / / | | | | | | | | | | | | | | | | Conflicts: etc/inc/vpn.inc
* | | | Specify $myid rather than %any here, otherwise user manager and mobile PSKs ↵Chris Buechler2015-06-211-3/+4
| |/ / |/| | | | | | | | | | | | | | | | | won't match. Ticket #4781 Conflicts: etc/inc/vpn.inc
* | | Ticket #4746 Correctly set global variables to be used by hostnames cod epathsErmal LUÇI2015-06-192-4/+6
| | |
* | | Merge pull request #1724 from phil-davis/patch-3Renato Botelho2015-06-190-0/+0
|\ \ \
| * | | Say what is happening when reinstalling package GUI XMLPhil Davis2015-06-161-1/+3
| | | | | | | | | | | | | | | | At the confirmation dialog after pressing the "Reinstall XML" button, the text does not distinguish between having pressed "Reinstall the whole package" and "Reinstall the GUI/XML". It would be nice if the text of this confirmation allowed the user to be confident about which button they had just pushed, before confirming the action. Note: This stuff has no gettext() wrappers - but that can be fixed later, not get mixed up in this.
* | | | Add a GUI field to increase the pf frag entries limit. Fixes ticket #4775jim-p2015-06-182-0/+22
| | | |
* | | | chmod +x hostidChris Buechler2015-06-181-0/+0
| | | |
* | | | Blacklist invalid "from" sources since they can be picked up accidentally ↵jim-p2015-06-171-1/+3
| | | | | | | | | | | | | | | | and cause rule errors. Fixes #4772
* | | | Say what is happening when reinstalling package GUI XMLPhil Davis2015-06-161-1/+3
| | | | | | | | | | | | | | | | | | | | At the confirmation dialog after pressing the "Reinstall XML" button, the text does not distinguish between having pressed "Reinstall the whole package" and "Reinstall the GUI/XML". It would be nice if the text of this confirmation allowed the user to be confident about which button they had just pushed, before confirming the action. Note: This stuff has no gettext() wrappers - but that can be fixed later, not get mixed up in this.
* | | | Add load_balancer_relay_* to obsolete files. They were removed from the ↵jim-p2015-06-161-0/+4
| | | | | | | | | | | | | | | | master branch already.
* | | | Merge pull request #1723 from phil-davis/patch-2Renato Botelho2015-06-161-0/+1
|\ \ \ \ | |/ / / |/| | |
| * | | Why is break missing for reinstallxmlPhil Davis2015-06-161-0/+1
|/ / / | | | | | | | | | | | | I thought that "reinstallxml" should do less than "reinstallpkg" but actually it was getting stuff here, then falling through "reinstalpkg" which did delete_package_xml and then install_pkg, which got the files a 2nd time and... Maybe that was supposed to happen? Anyway, I thought I would point this out and someone can either commit this pull request if the "break" should be there, or explain to me why "reinstallxml" is supposed to fall through executing all this code.
* | | Encoding in services_unbound_advanced.phpjim-p2015-06-161-2/+2
| | |
* | | Encoding in system_advanced_sysctl.phpjim-p2015-06-161-7/+7
| | |
* | | Encoding in interfaces.phpjim-p2015-06-161-4/+4
| | |
* | | Encoding in services_unbound.phpjim-p2015-06-161-1/+1
| | |
* | | Encoding in pkg_mgr_settings.phpjim-p2015-06-161-1/+1
| | |
* | | Encoding in system_advanced_admin.phpjim-p2015-06-161-1/+1
| | |
* | | Encoding in interfaces_ppps_edit.phpjim-p2015-06-161-2/+2
| | |
* | | Encoding in diag_packet_capture.phpjim-p2015-06-161-3/+3
| | |
* | | Encoding in interfaces_qinq_edit.phpjim-p2015-06-161-1/+1
| | |
* | | Encoding in services_dnsmasq.phpjim-p2015-06-161-1/+1
| | |
* | | Encoding in vpn_ipsec_settings.phpjim-p2015-06-161-1/+1
| | |
OpenPOWER on IntegriCloud