| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |
|
| |\ |
|
| | | |
|
| | |
| |
| | |
Clarify that this applies to DNS Resolver as well. Update the translations template.
|
| | |
| |
| | |
Clarify that this applies to DNS Resolver as well.
|
| |/
|
| |
Clarify that this applies to DNS Resolver as well.
|
| |\ |
|
| | | |
|
| | |
| |
| |
| | |
As suggested by Renato.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
1) A disabled gateway can always be enabled - no extra validation
needed.
2) When disabling an enabled gateway, check to see that the gateway is
not used in any gateway group or enabled static route (similar tests to
what is already checked before deleting a gateway).
3) A static route can always be disabled - no extra checks needed.
4) When enabling a static route, check that the selected gateway is
enabled - you cannot have a static route enabled on a disabled gateway.
5) Do the address family cross-check between static route and gateway
even when the static route is disabled - we do not want to save
mismatched IP address families in any case.
This covers all the cases I can see to ensure that the enable/disable
status combinations of Gateways and Static Routes is always valid.
|
| |\ \ |
|
| | | |
| | |
| | | |
... so that people can get useful descriptions in the System Logs - Firewall GUI, instead of useless tracker numbers. This is for master branch.
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Create a host-type alias. Put just a number in "IP or FQDN" - e.g. I made alias name "Zqw" and a single host "23". The webGUI reports:
There were error(s) loading the rules: /tmp/rules.debug:44: syntax error - The line in question reads [44]: table { 23 }
and /tmp/rules.debug has:
table { 23 }
Zqw = ""
which pf does not cope with.
This change will differentiate between a number in the context of a port alias and a number that is_hostname.
This time I think it really works :) The call to alias_get_type() needed to send the alias name as parameter. alias_get_type() is a bit expensive - it scans through the whole list of aliases looking for a match on the name. So I made this code just call it once for the name and then use that $alias_type var each time as it loops through all the addresses in an alias.
I have tried this successfully with a few combinations of nested port/host/network aliases. But maybe there is some wacky combination of nested aliases possible that could still break this? I don't see how, but it needs testing on some configs that have all sorts of nested alias types.
|
| |\ \ \ \
| |_|/ /
|/| | | |
|
| | | | |
| | | |
| | | | |
The GUI should show descriptions according to what's selected from the dropdown, but currently does not for URL Table (IPs) and URL Table (Ports) type of aliases.
|
| |/ / /
| | |
| | |
| | | |
unnecessary loop that'll amplify notifications unnecessarily.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
- Do not add leftid to confir when value is empty
- When asn1dn param is in binary form, explicit type
- Always add double quotes for asn1dn
|
| |/ / |
|
| | |
| |
| |
| |
| | |
- Add a upgrade code to fix asn1dn string format to match strongSwan needs
- Bump config version to 11.8
|
| |\ \ |
|
| | | |
| | |
| | | |
Improve this a little more to match only alpha after /dev/cua (/dev/cuau for example)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It originally coped with things like cuau1 cuau1.1
Then I made it cope with things like cuau1 cuau11 but it stopped working for cuau1.1
This one copes with:
cuau1
cuau1.1
cuau1.11
cuau11
cuau11.1
cuau11.11
That should allow for all sorts of reasonable device name files without matching other stuff in /dev (like cuau1.init cuau1.lock) that we need to ignore.
Please think if I have covered the bases here.
|
| | | |
| | |
| | |
| | | |
This reverts commit 0e19c4bba659a5f4d28f9c8b20c80717a90964b9.
|
| | | |
| | |
| | |
| | |
| | | |
Conflicts:
usr/local/www/vpn_ipsec_phase1.php
|
| | | |
| | |
| | |
| | | |
is asn1dn. Ticket #4792
|
| |/ / |
|
| | |
| |
| |
| | |
This reverts commit 81a73bcba3b3a79bb3a7add2e14a46e6af748f50.
|
| |\ \ |
|
| | | |
| | |
| | | |
Actually there was no real problem, but having a mis-spelling like this means that English speakers will waste time (like I did) double-checking to see if the mis-spelling would cause a real problem.
|
| |\ \ \ |
|
| | |/ /
| | |
| | |
| | | |
If you open firewall_aliases_import and enter just an invalid Alias Name (e.g. a$b) and press save or press save with all fields empty, then the screen redraws but the input error(s) is not displayed.
This fixes it.
|
| |\ \ \ |
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
If you click "+" to add an alias, then press Save without entering anything, you get:
Warning: Invalid argument supplied for foreach() in /usr/local/www/firewall_aliases_edit.php on line 402
as well as the various messages related to $input_errors.
This change ensures that $input_addresses array always exists (even if it has no real entries) so that the foreach() warning does not happen.
|
| |\ \ \ |
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Create a host-type alias. Put just a number in "IP or FQDN" - e.g. I made alias name "Zqw" and a single host "23". The webGUI reports:
There were error(s) loading the rules: /tmp/rules.debug:44: syntax error - The line in question reads [44]: table { 23 }
and /tmp/rules.debug has:
table <Zqw> { 23 }
Zqw = "<Zqw>"
which pf does not cope with.
It is possible to have a host name that is a number, and end up with a domain name like 23.mycompany.com - unfortunately some Wally allowed such things in standards many years ago, so it can be rather difficult to tell the difference between a number and a host name.
This change improves the check when looking through alias entries and deciding if they are meant to be a name or a "bottom-level" value (address, subnet, port, port range). Anything that ends up looking like a host name gets given to filterdns to sort out. "Names" like "23" now get given to filterdns instead of being put directly into the table in pf. This makes things happier. Even if filterdns cannot resolve "23", at least it tries and nothing barfs.
|
| |\ \ \ |
|
| | |/ /
| | |
| | | |
Make the required fields be correct and match thier text names, which should each have their own gettext() cal so as to build a proper array at line 81. Basically it was all broken and the errors displayed when field/s were left empty were rubbish.
|
| |\ \ \ |
|
| | |/ /
| | |
| | |
| | | |
The reqdfields had only 4 entries but reqdfieldsn has 5 entries and the field names to text descriptions did not match up.
Fixed it.
|
| |\ \ \ |
|
| | |/ /
| | |
| | |
| | | |
If you go to Interfaces, assign, PPPs, press "+" to add an entry, then press Save without entering anything then you get a warning about the foreach() here.
The is_array() check fixes it.
|
| |\ \ \ |
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If there is an input error then the edit page is redrawn showing the
input errors. The HTTP_REFERER becomes the current page, rather than the
true original referer. Then if you click Cancel the current page is just
redrawn.
This change makes the code remember the original referer, so if the user
enters some invalid data, presses Save, reads the input error messages
then presses Cancel they are taken back out to the original page - the
same as if Cancel was used before Save.
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | | |
Removing the "." that was in {,.[0-9]} allows it to match /dev/cuau10 and onward.
I added lots of comments on the glob expression, because the format of the glob expression is not the same as an ordinary regex.
|
| | | | |
| | | |
| | | |
| | | | |
specified.
|
| |\ \ \ \
| |/ / /
|/| | | |
|
| |/ / /
| | |
| | | |
The current implementation is not working for me, maybe the interface was changed by GratisDNS? I tested the update URL manually with the IP added ("&i=<ip>") which fixed the issue for me. Code adjusted to include IP.
|
| |\ \ \
| |/ /
|/| | |
|
