summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Required fields for System pagesPhil Davis2017-01-3016-87/+111
| | | | (cherry picked from commit 153c3aa61fe65c51d584a57c032a4805048e3062)
* Misc cleanups at get_pkg_info()stilez2017-01-301-34/+34
| | | | | | | | * rename function args to be clearer what they do ($local_only was quite ambiguous, at first sight it could mean any of: "don't update local catalog copy", "only check local catalog copy", or "only report local installed pkgs") * merge nested if () conditions * refactor minor code stuff * rewrite explanatory comment (cherry picked from commit 04daf8b1f016e17bede4ad00db46f2855d3e7c1f)
* fix copy/paste - I think!stilez2017-01-301-32/+6
| | | | (cherry picked from commit 2f633b526075b2ed5e0e160ef6f0d025b509bd70)
* use wrapped version of pkg info -e insteadstilez2017-01-301-5/+31
| | | | (cherry picked from commit e5f96a2cb3c0cad0c828148bd7b8d45c130a9b17)
* get_pkg_info() fallback using pkg info if no local copy of repo catalog ↵stilez2017-01-301-6/+34
| | | | | | | | | | | | | | | (resubmit) Resubmit of PR #3157 with fix. The issue in #3157 was that `pkg info` and `pkg search`, undocumented in man pages, seem to handle things differently if no packages match the pattern string. `pkg search` gives an error "No packages match [$pkgs]", whereas `pkg search` doesn't give an error. I didn't come across this because it's not stated in the man pages for pkg info, and because I tested it with a bare install but at least one pkg, while @NYOB used it on a bare install. The fix which I've tested and seems to work nicely, is to test using `pkg info -e` whether the pkg info call will hit a "no packages exist" issue or not. If `pkg info -e` returns 0 then it's safe as there's at least one matching pkg (any other errors are allowed to occur and be detected as usual). If it returns anything else, then there's no matching pkgs, so the main `pkg info` is skipped leaving $out and other variables at the correct values they need anyway, showing a null match/none found. For details of the underlying issue being fixed, and the issue that this resubmit fixes, see the original PR. (cherry picked from commit 587988f6df7e1d3b1a369b93a5634620129e3d9d)
* More required fields for NAT pagesPhil Davis2017-01-304-9/+9
| | | | (cherry picked from commit 877be5e6205ada2608b364f57150010ba473e66d)
* Required fields in NAT pagesPhil Davis2017-01-304-9/+9
| | | | (cherry picked from commit f2e58c16307795f572ff443e999c54eb6a9839e7)
* Required fields in diagnosticsPhil Davis2017-01-305-7/+7
| | | | (cherry picked from commit 3e2028f4dca359e715058d2c35ae0df5b939657e)
* More required fields for Interface pagesPhil Davis2017-01-306-9/+9
| | | | (cherry picked from commit fb572e810abe247c273c27ffafb129430b13be1f)
* Use gettext on Username and PasswordPhil Davis2017-01-301-2/+2
| | | | (cherry picked from commit e52b5a409faa41222a4ff0c917355eb66d0ff19a)
* Required fields in Interfaces pagesPhil Davis2017-01-309-27/+46
| | | | (cherry picked from commit 1095b20410963e748fe13268e6fa8f35ccce2319)
* Required fields in Status pagesPhil Davis2017-01-302-2/+2
| | | | (cherry picked from commit f311d3ba11572364488ee25ca9df08a33e42a089)
* Remaining required fields for Diag pagesPhil Davis2017-01-305-10/+10
| | | | (cherry picked from commit fe54f09154f4116ceea6897bff54a624f1eb63bc)
* Required fields for firewall*.phpPhil Davis2017-01-303-13/+23
| | | | (cherry picked from commit 8a1b5c561f93611b711eb4e7b58ccb4990577d8e)
* Required fields for Captive PortalPhil Davis2017-01-306-17/+17
| | | | (cherry picked from commit c06865be6de6b164d06ee9bb1768dfe6829d783c)
* Required fields in Services pagesPhil Davis2017-01-3020-47/+71
| | | | (cherry picked from commit 24b82516e0baac87316245427e870a36fbcda4ac)
* Fix indentationjskyboo2017-01-272-13/+13
| | | | (cherry picked from commit c18d0d12b3e683f07b4bac933240332cd4d95829)
* Changed max repeat alert to use sprintf get textjskyboo2017-01-271-1/+1
| | | | (cherry picked from commit 950342400bdc75b35c01442c400bd53a18015818)
* Bug #7164 Limit NTP time source fields to the maximum number saved to ↵jskyboo2017-01-272-2/+13
| | | | | | configuration. (cherry picked from commit 5a1d67b17d485697e19ef49d66e8e5f91e7e884d)
* Typo in pppoe_subnet input error messagePhil Davis2017-01-261-1/+1
| | | | (cherry picked from commit 01799e5bd5f363e21c744752760ab0cc591713da)
* Captive Portal auth method is requiredPhil Davis2017-01-251-2/+6
| | | | | | When creating a new Captive Portal Zone the user can fail to select any of the Authorization Method radio buttons. No default radio button is selected - that is probably good, as the user has to think and click to decide which authorization method they will use. But the form validation should check that some valid value is POSTed when the CP is enabled. (cherry picked from commit 0ee22f364ca62b8305ff36447954dacdbc3c3cce)
* CP HTTPS Forwards setHelp formatPhil Davis2017-01-251-1/+1
| | | | | Add full stop and spacing between sentences. (cherry picked from commit 0046a7da59fb3015512ce181cba6b37516c0b76f)
* Changed default state of GPS init command auto correct tool.jskyboo2017-01-251-3/+3
| | | | (cherry picked from commit 2559f37539cf37221f8fddd7c0b7928e8e3969a8)
* Feature #7159 Add GPS initialization command auto correct tooljskyboo2017-01-251-2/+45
| | | | | | Corrects malformed NMEA sentences by calculating and appending the checksum and adding missing special characters "$" and "*" (cherry picked from commit 8c23d92a159c1282e7d185665977f0c45d45f845)
* Require at least one tag value in a QinQ entryPhil Davis2017-01-241-0/+4
| | | | (cherry picked from commit 4085eb055850e07540145c87fd6d3b5912a865dd)
* Use is_intrange() to validate QinQ tag rangePhil Davis2017-01-241-39/+13
| | | | | | Note: is_intrange() only tells us that the range is good and might be delimited by a "-" or a ":", so if we want to take apart the 2 parts of the range (like is done here) we have to also test the string to decide which separator to use. I decided it is fine to accept ranges with a ":" separator. Even though it is not explicitly mention on the UI, a user who accidentally does it will be pleasantly happy that it works. (cherry picked from commit 71ff866c0b36c6a3e288e8bde02d0837fc0b73ce)
* QinQ Tag Value ValidationPhil Davis2017-01-241-7/+27
| | | | | | Tags must be in the range 1 to 4094 Flag the various input errors and only report them once each. (cherry picked from commit e0b7a2e76bddd121bc7f92a6ecb20266c8485ed1)
* QinQ Edit fix row add deletePhil Davis2017-01-241-16/+46
| | | | | | | | 1) Make the row delete button actually work 2) Do not allow ranges that go backwards like 25-20 or just "-" or 1-sided ranges "-42" "42-" 3) Remember the POSTed stuff to redisplay to the user if there were input errors 4) Ranges or numbers entered could overlap - just save a list of the unique members. e.g. If the user enters 5-15 and 10-20 (cherry picked from commit 477d849bd4e85af8bb3595eaf39f946de51d7289)
* change opacity on disabled rows to fix #6448Jared Dillard2017-01-242-2/+37
|
* Introduce is_intrange() to validate a range of integers delimited by ':' or '-'Renato Botelho2017-01-241-0/+29
|
* Merge pull request #3166 from NOYB/System_Update_Settings_-_GitSync_OptionsRenato Botelho2017-01-242-1/+78
|\
| * System Update Settings - GitSync OptionsNOYB2017-01-222-1/+78
| | | | | | | | | | | | | | Add GitSync options selectors to post update GitSync. Minimal, Diff, Verbose, Dry Run The GitSync options have utility for post update sync also.
* | Validate POSTed interface descriptionPhil Davis2017-01-241-1/+1
| | | | | | | | | | Copy-paste error from code that used $_REQUEST. This is more correct to use $_POST. (cherry picked from commit b07adc116c47a2f6a27ae69c84fe0e36a5a27fbd)
* | Interface description should be requiredPhil Davis2017-01-241-21/+28
| | | | | | | | | | | | I was blanking out stuff to see what input error messages came about fields that are required. I was surprised that the Interface Description would save empty. The system did not immediately explode (I was playing with a bonus interface I had created in a VM) but I don't think it is desirable to have interfaces with no description. The change here also only does the other checks on the description if it has actualy been entered - no point checking a whole lot of other dependent stuff if the description is not even entered. (cherry picked from commit f57a3d9051f904f7b915db0bc0b64849503f8647)
* | Interface Group Name should be requiredPhil Davis2017-01-241-30/+37
| | | | | | | | | | | | Do not allow it to be blank. Do not bother with all the other checks on the group name if it is blank. (At the moment I can enter an Interface Group with blank name) (cherry picked from commit 3effec3b515a97e3b5820ba8687645868b807463)
* | traffic-graphs, setting to keep updating them while invisiblePiBa-NL2017-01-233-159/+108
| | | | | | | | | | - allow showing different graphs to be shown on different browser tabs (dont use localstorage for graphs to query) - show interface name in graph instead of realname
* | Parse GPS initialization commands, extended status for GPSs other than ↵jskyboo2017-01-233-58/+156
| | | | | | | | | | | | | | | | | | | | | | SureGPS and make optional. - Parse GPS initialization commands for explicitly configured GPS commands - Add extended GPS status if GPGSV or GPGGA are explicitly configured - Add config option to toggle extended status - Clean up some variables on status page and widget. (cherry picked from commit d627983d2504e56015e14f1f85a4eb6b70a5eea9)
* | Force compress for where_is_ipaddr_configured check_localipPhil Davis2017-01-231-1/+1
| | | | | | | | (cherry picked from commit f0b1358dfe520ad3b771127127daed970ba2c0a0)
* | Force compress for where_is_ipaddr_configuredPhil Davis2017-01-232-2/+6
| | | | | | | | (cherry picked from commit cde28bfa0e11f268485ec1f6ccb73a3a2f66448f)
* | Always force compress when calling Net_IPv6Phil Davis2017-01-236-13/+28
| | | | | | | | (cherry picked from commit 587995fb57f91894d1f8eb6b296a9fe2fa111fac)
* | Interface description must be unique including casePhil Davis2017-01-233-5/+5
| | | | | | | | (cherry picked from commit 3692adec74d438eedb41a7be8eae9cd58f6fe5c1)
* | Required fields in Load Balancer pagesPhil Davis2017-01-233-7/+7
| | | | | | | | (cherry picked from commit 275d769e0d99e02984e42e2328cbcb681f9b87fb)
* | firewal_nat_edit function name typoPhil Davis2017-01-231-1/+1
| | | | | | | | | | | | This unrelated fix is in a big diff listing of other stuff related to a proposed RADIUS enhancement https://github.com/pfsense/pfsense/pull/3407/files#diff-f080be89fa12ff3c28d7467b12985d09 The accidental typo should be fixed, rather than getting stuck in that other PR. (cherry picked from commit ada9b6bc1f7ab135bbc806b0e064dcbfbaa88c56)
* | 6RD Border Relay input error messagePhil Davis2017-01-231-1/+1
| | | | | | | | | | | | This field is labelled "6RD Border Relay" on the main UI. It confused me for a moment when I got this message "6RD Border Gateway must be an IPv4 address." since there was no field with that label in the 6RD section of the UI. It would be good to use the same terminology in both places. (cherry picked from commit 1a9ec5cc9ead61a7ceb814209e245a14c79db53a)
* | Add required fields to firewall_aliases_importPhil Davis2017-01-231-2/+2
| | | | | | | | (cherry picked from commit b6368b73d921a29e87cc1cd02ab912024ba66d0a)
* | Display input error when no aliases to importPhil Davis2017-01-231-2/+2
| | | | | | | | | | Currently if you put nothing in the "Aliases to import" box and press Save then the page just reloads - nothing saves and there is no message about the problem. It should tell you to that "Aliases to import" is required. (cherry picked from commit f99bbf5e01f71ba21ff6ed0b95d47b1b7d163154)
* | Remove unused variable $cfglckkeyconsumersRenato Botelho2017-01-231-5/+3
|/
* Internationalization (getttext)NOYB2017-01-201-1/+1
| | | | | | Please also backport to 2.3 (cherry picked from commit d0718a0f9031f9dc7c6eff3e47e472178c900ece)
* Fix #7141 Add a priv for UPNPPhil Davis2017-01-191-0/+6
| | | | | | so users can grant access to Services->UPNP Note: Status->UPNP already has a priv and it works. (cherry picked from commit a5a899e4388f2737a6d1cdc82c7325c20fb72ee4)
* Fix #7139 Accessing help about this pagePhil Davis2017-01-191-1/+1
| | | | | from a user that does not have admin or all page privilege. (cherry picked from commit 166540830275318c8dec9199d8a9ee0e605f606a)
OpenPOWER on IntegriCloud