| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
(cherry picked from commit 7bba13e8d53adfe4beb03c8444e60848ae6e25e9)
|
|
|
|
|
| |
If I try to delete an alias that is in use, the "cannot delete alias" message was being displayed as the "success" color.
(cherry picked from commit 04b571e836077c436d109d982be5a8e710ff8aab)
|
| |
|
|
|
|
| |
(cherry picked from commit a0b0acd1540764d5221ea54ea596d569bbe2df2a)
|
|
|
|
| |
(cherry picked from commit 5810f934472368f43942ea66820dc98e17143c19)
|
|
|
|
| |
(cherry picked from commit a654d899cd5d288501fea1ec52dba2e3f0e479ba)
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
At present, when doing a System Update, there is a message box that says:
"Please wait while the installation of completes.
This may take several minutes."
Between "of" and "completes" is the package name, which is blank in the case of a System Update.
This should fix that issue by defining $pkg_wait_txt appropriately for the $firmwareupdate case.
Note: It was also easy to refactor out a couple of special "if firmwareupdate" tests, as the code "fell out" nicely by defining the other *_txt variables to suitable strings for the $firmwareupdate case.
|
|
|
|
| |
https://forum.pfsense.org/index.php?topic=114570.0
|
| |
|
|
|
|
| |
(cherry picked from commit 1c10ce9750f3702f433a91754f79e637e1c3369b)
|
|
|
|
| |
(cherry picked from commit 54691fc663eae7c6e92e4eaad596906758d7ebea)
|
|
|
|
| |
(cherry picked from commit 658180daffe0fe5f005b6fe6b528c758309dffef)
|
|
|
| |
Use of undefined constant min - assumed 'min'
|
|
|
|
| |
Use of undefined constant min - assumed 'min'
Use of undefined constant max - assumed 'max'
|
|
|
|
| |
Notice: Use of undefined constant min - assumed 'min'
Notice: Use of undefined constant max - assumed 'max'
|
|
|
|
| |
Use correct Thursday abbreviation (s/Thr/Thu/).
|
| |
|
|
|
|
| |
#6560
|
| |
|
|
|
|
| |
memory on systems with large state tables. Ticket #6364
|
|
|
|
|
|
|
|
|
|
|
| |
dpinger stopps with an error when the socketname exceeds over
(around) 100 characters. The dpinger will not start and not deliver
monitoring results to the WebUI.
These long socket names can get created when using link-local addresses
and long gateway names / interface scopes.
See Ticket 6505
|
|
|
|
|
|
|
| |
Currently underscores are used to seperate gwifip, monitorip, etc, but
underscors are also used in vlan subinterfaces like em0_vlan10 and
therefore can't be used because the interface scope is appended to IPv6
link-local addresses.
|
|
|
|
| |
set_sysctl out if the block where it only gets run if dummynet isn't already loaded. Ticket #6553
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing regex here is wrong, it matches 0 or more of the hex digits but then there can be other rubbish in the string, in fact anything at all! It matches "az", "z", "qwerty" and so on. So the "return false" inside this "if" never happens.
In most cases the later code catches problems, because it converts the string from hex to decimal (and things like "z" end up as decimal 0), then it does some back-conversion of the answer to hex and realizes something is different and so does not count the entry as one of the needed 8 valid segments of the IPv6 address.
This goes wrong if the user supplies a string with 8 valid IPv6 hex pieces and 1 or more extra invalid ones anywhere in the list. In that case the code finds 8 good chunks and thinks that all is well.
Try using the pfSense is_ipaddrv6() with strings like:
$ipaddr = "1:2:3:4:5:6:7:z:a";
$ret = is_ipaddrv6($ipaddr);
var_dump($ret);
That returns true - which is not good!
You can put the invalid items anywhere you like, as long as you have 8 valid items, such as:
"1:2:3:xy:4:5:6:7:8"
"gh:1:2:3:xy:4:5:6:7:8"
"1:2:3:xy:4:5:6:7:8:qw"
This change makes this initial validity check on the characters actually work, so it avoids the later code having to deal with that at all.
(cherry picked from commit 8a950b3c3765f5349983130611354bfead0abafb)
|
|
|
|
|
| |
It seems to me that a through f should not be part of the pattern for the "V4" case.
(cherry picked from commit 1f49dd8a3a49b724ded5840c1db6c168ed466aae)
|
|
|
|
|
|
|
|
|
| |
The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required.
It seems to me that there is no harm at all in always using
require_once().
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
flipping based on direction is wrong. Ticket #6530
|
| |
|
| |
|
|
|
|
| |
Ticket #6506
|
|
|
|
| |
(cherry picked from commit b069f77e0a5e355e811dd7bd4a4d17a802a3f682)
|
|
|
|
|
|
| |
settings"
This reverts commit fc76a1e390c8ce9579df31457c74d1d0e572b78d.
|
|
|
|
| |
(cherry picked from commit 5c403f843291bdc670dcdb45e1e097f2eb7f36ab)
|
|
|
|
|
| |
This is a string from a list of valid values (empty, "hostonly", "fqdn"). So it is not correct to just gather a true/false value here.
(cherry picked from commit e93242eb2ad5a45fb6ab1526f0b6ddcc716e5b96)
|
|
|
|
|
|
|
|
| |
update/remove/install
Added comments to clarify operation of the page
(cherry picked from commit 18295ff2f907f638afa9f7c665cc16e4262e6899)
|
| |
|
| |
|
|
|
|
|
|
| |
Apparently gettext() does not behave correctly when passed an empty string, this commit ensures gettext() is called only with non-empty strings
(cherry picked from commit 6ae99aba5cab12440d88dd9ddaa6535c3b9b5d82)
|
|
|
|
| |
(cherry picked from commit 40d7e4bee91246db09cc88141869abcd37390bc7)
|
|
|
|
|
| |
Function isn't used in main or packages repo, and in any case would need a complete rewrite to handle IPv6.
(cherry picked from commit 6215902c4043726e633fcfac1c37c710ac398653)
|
|
|
|
|
|
| |
This fixes the GUI inconsistency reported in the referenced bug. On edit of an OpenVPN server that has tun mode, not shared key, and the gwredir checkbox checked, the local_network fields are shown, but actually they should be hidden (because that is what happens on first data entry when gwredir is checked).
At least this makes the GUI consistent. Then the other issues mentioned in Redmine feature 6483 can be addressed separately.
(cherry picked from commit fa20dac1b58488713d88b44cafc760a83d79cb66)
|
|
|
|
| |
(cherry picked from commit e8406abe627675db2c2f77a81c1bb883f5158bb6)
|
|
|
|
|
|
| |
If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)
(cherry picked from commit 9f4722022f0e8114741e8cf1a421520fded8be1f)
|
|
|
|
|
|
| |
With this change single-quotes are applied in correct places
(cherry picked from commit 08cd022545be58a46b860500ff81bbe7438b6304)
|