| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\ |
|
|/
|
|
|
|
|
|
|
| |
While trying to see why this is not working for me (forum https://forum.pfsense.org/index.php?topic=83651.0 ) I have fixed some little things:
1) Get the new-lines right so the output of the restarting looks neat
2) Fix a comparison that had just a single equal sign - it did not break anything real because the subsequent code was just text output to the console. Now that text output does take notice of the correctly-evaluated condition, and $interface is not overwritten.
The issue in the forum post, about the interface IP address config not actually changing, is still the case, at least for me.
IMO these little tidy ups might as well be committed. They make this code better!
|
| |
|
| |
|
| |
|
|
|
|
| |
Fixes #3361
|
|
|
|
| |
Fixes #3361
|
| |
|
|
|
|
| |
problems of overriding default gateway by dynamic interfaces. Try to stick to the first found for now!
|
|
|
|
| |
only IP changes that end up here (by design).
|
| |
|
|
|
|
|
|
| |
hidden config option to wipe all states on IP change, as there seemed to
be circumstances where the 'pfctl -k $oldip' didn't suffice for others
(much of history in redmine ticket, some on forum and elsewhere). ticket
|
| |
|
| |
|
|
|
|
| |
ticket #3933
|
| |
|
| |
|
|
|
|
|
|
|
| |
value. That's a separate issue that needs fixing upstream, but in the mean
time, we can work around it by removing all CARP VIPs in the same way we
do when "Temporarily Disable CARP" is chosen before adding them all back.
Ticket #3910
|
|
|
|
| |
more testing. ticket #1629
|
|\ |
|
| | |
|
| | |
|
|\ \ |
|
| | |
| | |
| | | |
There is currently no code to convert an IPv6 range to a set of corresponding IPv6 subnets, so warn the user if they attempt that from the alias bulk import GUI.
|
| | |
| | |
| | | |
so that it can be used for expanding ranges in host alias input.
|
| | |
| | |
| | |
| | |
| | | |
When entering a host alias, if the user put an IP range (like 192.168.0.10-192.168.0.20) or a subnet (like 192.168.1.200/29) then expand it into a list of individual IP addresses. Check that it will not make too many rows to exceed the existing 5000 row limit on the GUI.
Note: expanding ranges and subnets like this is only for IPv4 for now. Entering an IPv6 range or subnet in a hosts alias will display a message telling the user that is not supported - it could be done in future but currently the routines that convert this stuff are only for IPv4.
I have done as much validation as I can think of, and where there is a problem the original user-entered data is preserved for re-display, as well as the input errors being displayed. So IMO it should be self-documenting.
|
| | |
| | |
| | | |
to minimize risk of a problem when adding code here in the future.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently if you enter a space-separated list of subnets in the IP address box when entering an alias, the code reports that the data is invalid. But it does actually expand the list of subnets into multiple rows, and enters the various subnet CIDRs into the CIDR column for the user. The user can press Save a second time and the data is now valid so the code saves it happily. This is rather odd, as reported in redmine #3890.
Also, if you input an IP range (e.g. 192.168.20.0-192.168.20.30) plus description and in the 2nd row put some other subnet and description, the range is correctly expanded, but the description only appears against the 1st subnet of the range. The description from the 2nd row ends up as the description against the 2nd subnet of the range, and the rest of the descriptions are blank. i.e. the descriptions do not get copied and pushed down as the IP ranges are expanded.
This change fixes all that stuff by first parsing the posted data and expanding any IP ranges and/or space-separated lists, building arrays that have all their entries lined up:
$input_addresses[]
$input_address_subnet[]
$final_address_details[]
which are then validated.
This is for master (2.2) branch. Actually it was not too difficult to integrate.
|
| | |
| | |
| | |
| | | |
logical condition to create a new cert if crt or key is not present
|
| | |
| | |
| | |
| | | |
changes of go outside the sidget. It should fix #3937
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
page and handbook (only the latter is actually used). Change this to just not use domain, and set the search to the system's domain where not using the function that generates the search list for dynamic WANs.
|
| | |
| | |
| | |
| | | |
https://forum.pfsense.org/index.php?topic=79737.msg452808#msg452808
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | | |
Fixes redmine #3950 - ip_range_to_subnet_array can easily swap the input parameters if the caller has passed/entered them the wrong way around. That is both friendly to the caller and ensures that a hostile caller can't blow up the routine.
This patch is for master (2.2)
|
| | | | |
|
|/ / /
| | |
| | |
| | | |
waste of screen space
|
| | | |
|
| | |
| | |
| | |
| | | |
implied), so allow that here. Fixes wrong input validation in parts of nsupdate GUI, among other things.
|
|\ \ \ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|