| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
| |
This made the piep configuration to be wrong at least for passthrough entries. Ticket #3932
|
| |
|
|
|
|
|
|
|
|
| |
When a dynamic gateway is disabled (by the user through the webGUI), it was still being returned by return_gateways_array(). But when called like that, disabled gateways should not be returned. The first part of the routine was correctly skipping disabled gateways, but then the later part would effectively re-generate those dynamic gateways on-the-fly and not realise they should be skipped because they were disabled.
This code now remembers gateway details of all the gateways, including skipped ones, so the dynamic gateway code can easily realise all gateways that have been already processed, even those that were processed and skipped.
Forum: https://forum.pfsense.org/index.php?topic=86565.0
It fixes Gateway Status Widget - now if a dynamic gateway is disabled, it does not appear on the display.
This will also stop disabled dynamic gateways from being returned to other callers. So there may/will be impacts on other parts of the system when a user disables a dynamic gateway. e.g. filter.inc - a gateway that has been disabled by a user canot be used in rules any more.
|
| |
|
|
|
|
| |
special chars in shell and HTTP GET parameter passing. Probably should add POST support to fcgicli.
|
|
|
|
|
|
|
| |
Obviously a typo. But this section is inside:
if (isset($_POST['add_x']) && isset($_POST['if_add'])) {
and I cannot find where 'add_x' is ever sent here, so I do not see how this whole code section is ever executed (and that will be why this typo bug has no symptoms). What is the history here? Can the whole block of code be removed?
The code normally executed is the section for 'Submit' lower down.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
name is the one needed here.
|
| |
|
|
|
|
|
|
| |
out too. Revert "PEAR static method call warning"
This reverts commit 4751f76a6772147097906b699d4216ae38c58c39.
|
|
|
|
|
|
| |
messages"
This reverts commit 91b9a02fb131746c67fdf9f34282f123a13f1b13.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Forum https://forum.pfsense.org/index.php?topic=86478.0
PEAR is used by
IPv6.inc
auth.inc
captiveportal.inc
radius.inc
xmlrpc_client.inc
radius_accounting.inc
radius_authentication.inc
I have just changed this 1 function to "public static"
Also used are:
PEAR::raiseError
PEAR::loadExtension (already has "static function")
Not sure if PEAR::raiseError will throw a similar "static method" call
warning, not game to touch it.
|
|
|
|
| |
with a crash report, this is more noise than useful at this stage in 2.2.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix various files that can emit messages like:
PHP Strict Standards: Non-static method SimplePie_Misc::array_unique()
should not be called statically, assuming $this from incompatible
context in /etc/inc/simplepie/simplepie.inc on line 5508
php-fpm[16262]: /rc.newipsecdns: PHP ERROR: Type: 8192, File:
/etc/inc/shaper.inc, Line: 4365, Message: Assigning the return value of
new by reference is deprecated
Some of these style messages have been reported on the forum, e.g.
https://forum.pfsense.org/index.php?topic=86448.0
I had RSS widget on, and simplepie sent the system beserk telling about
all this stuff.
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move redundant code to a function parse_aliases_file(). Before the max
number of items was not being respected when URL content is updated,
only when alias was saved. Same was happening with ip/subnet/port
validation and user could end up with a bad pf.conf
- Remove unused variables
These changes were based on Pull Request #1264. It should fix #4189
Submitted by:▸ PiBa-NL
|
|
|
|
| |
be run if the VIP is in the INIT state.
|
| |
|
|
|
|
| |
would need a refresh to check if cookie was set or not. Use javascript to do a simple test
|
|
|
|
| |
parameters were out of order and expiration time was being set as value. It should fix #4069
|
| |
|
|
|
|
| |
it for now at least. Ticket #4186
|
| |
|
|
|
|
| |
updated accordingly some time ago, and an employee with Cox Communications has confirmed this allows things to work on their circuits deployed with /31s. Ticket #4190
|
|
|
|
|
|
|
|
| |
are placed strangely)
A few functions such as ipcmp(), subnet_expand(), and check_subnets_overlap() are in illogical places - away from all the other ip comparison and subnet basic functions and in the middle of alias handling and interface enumeration.
No change to functional code, just moving to earlier in the file (next to other IP compare and subnet functions) for ease of future contributors.
|
| |
|
| |
|
|
|
|
| |
connections. The dashboard will be fixed with the ticket already open. This should fix a lot of instabilities reported on the forums for people having a dozen or more tunnels
|
| |
|
| |
|
|
|
|
| |
strongswan do proper behaviour. Also for DynDNS names use the dns type id so strongswan does the resolving by its own.
|
|
|
|
| |
previous behavior of setting it to the interface IP.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Also retires IPsec force reloading advanced sysctl since its useless nowdays with strongswan and remove its call on rc.newipsecdns.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OpenVPN create the tun/tap interface and, when set an IP address to
it, mark it as UP. In some scenarios, when TAP is set as bridge and
doesn't have an IP address set on it, it never goes up and tunnel
doesn't work.
If rc.newwanip is called for this TAP interface, UP flag is set, but,
rc.newwanip is not executed when system is booting.
Since it's always rename the interface and add it the group, make sure
it's up here.
|
| |
|