diff options
| author | Phil Davis <phil.davis@inf.org> | 2014-04-30 22:45:18 -0700 |
|---|---|---|
| committer | Phil Davis <phil.davis@inf.org> | 2014-04-30 22:45:18 -0700 |
| commit | b6ba57f67e16297fcb8b61460fb58f561122fdeb (patch) | |
| tree | 79900697ef6acf4d1f89defc0e3aa78fb210a4bc /usr | |
| parent | 25f7f725740f6e1bdd8f1d9fa4aea338d2e6d3e9 (diff) | |
| download | pfsense-b6ba57f67e16297fcb8b61460fb58f561122fdeb.zip pfsense-b6ba57f67e16297fcb8b61460fb58f561122fdeb.tar.gz | |
Fix Bug #3627 Diagnostics: Tables - Remove button dont work after update to PfSense 2.1.2
This annoyed me also, so I thought it worth finding what changes exactly broke this.
del_entry was broken on 2.1 branch by https://github.com/pfsense/pfsense/commit/fe3088b965a99772e76622d17ceae87288471edc
These 2 small changes make it work again without needing to reverse the other bits of stuff in that commit.
Note that Master does not have that commit at all. There are lots of these "XHTML Compliance" and similar commits in 2.1 branch that are not done in master. I don't understand why that is. Why don't those code cleanups also need to be applied to master?
Diffstat (limited to 'usr')
| -rw-r--r-- | usr/local/www/diag_tables.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr/local/www/diag_tables.php b/usr/local/www/diag_tables.php index fdfc99a..00eba74 100644 --- a/usr/local/www/diag_tables.php +++ b/usr/local/www/diag_tables.php @@ -106,7 +106,7 @@ if ($savemsg) print_info_box($savemsg); window.location='diag_tables.php?type=' + entrytype; } function del_entry(entry) { - jQuery.ajax("diag_tables.php?type=<?php echo htmlspecialchars($tablename);?>&delete=" + entry, { + jQuery.ajax("diag_tables.php?type=<?php echo htmlspecialchars($tablename);?>&delete=" + entry, { complete: function(response) { if (200 == response.status) { // Escape all dots to not confuse jQuery selectors @@ -154,7 +154,7 @@ if ($savemsg) print_info_box($savemsg); </tr> <?php $count = 0; foreach($entries as $entryA): ?> <?php $entry = trim($entryA); ?> - <tr id='table_row_<?=$count?>'> + <tr id='<?=$entry?>'> <td> <?php echo $entry; ?> </td> |
