XHTML Compliance

Interfaces - PPPs Edit

2 files changed, 37 insertions, 37 deletions

diff --git a/usr/local/www/interfaces_ppps_edit.php b/usr/local/www/interfaces_ppps_edit.php
index 034c42d..efa6f89 100644
--- a/usr/local/www/interfaces_ppps_edit.php
+++ b/usr/local/www/interfaces_ppps_edit.php
@@ -419,7 +419,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				</select> 
 			</td>
 		</tr>
-		<tr name="interface" id="interface" >
+		<tr id="interface" >
 			<td width="22%" valign="top" class="vncellreq"><?= gettext("Link interface(s)"); ?></td>
 			<td width="78%" class="vtable">
 				<select style="vertical-align:top" name="interfaces[]" multiple="multiple" class="formselect" size="4" onchange="show_hide_linkfields(this.options);">
@@ -429,7 +429,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				<br/><span class="vexpl"><?= gettext("Select at least two interfaces for Multilink (MLPPP) connections."); ?></span>
 			</td>
 		</tr>
-		<tr style="display:none" name="portlists" id="portlists">
+		<tr style="display:none" id="portlists">
 			<td id="serialports"><?php
 				$selected_ports = explode(',',$pconfig['interfaces']);
 				if (!is_dir("/var/spool/lock"))
@@ -469,7 +469,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				if($serport_count > $port_count)
 					$port_count=$serport_count;
 			?></td>
-			<td style="display:none" name="port_count" id="port_count"><?=htmlspecialchars($port_count);?></td>
+			<td style="display:none" id="port_count"><?=htmlspecialchars($port_count);?></td>
 		</tr>
 		<tr>
 			<td width="22%" valign="top" class="vncell"><?= gettext("Description"); ?></td>
@@ -478,9 +478,9 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				<br/> <span class="vexpl"><?= gettext("You may enter a description here for your reference. Description will appear in the \"Interfaces Assign\" select lists."); ?></span>
 			</td>
 		</tr>	
-		<tr style="display:none" name="select" id="select"><td style="display:none"></td></tr>
+		<tr style="display:none" id="select"><td style="display:none"></td></tr>
 		<?php $k=0; ?>
-		<tr style="display:none" name="ppp_provider" id="ppp_provider">
+		<tr style="display:none" id="ppp_provider">
 			<td width="22%" valign="top" class="vncell"><?= gettext("Service Provider"); ?></td>
 			<td width="78%" class="vtable">
 				<table border="0" cellpadding="0" cellspacing="0" summary="service provider">
@@ -495,7 +495,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 					<tr id="trprovider" style="display:none">
 						<td><?= gettext("Provider:"); ?> &nbsp;&nbsp;</td>
 						<td>
-							<select class="formselect" name="provider" id="provider" onchange="providerplan_list()">
+							<select class="formselect" name="provider_list" id="provider_list" onchange="providerplan_list()">
 								<option></option>
 							</select>
 						</td>
@@ -525,45 +525,45 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 			</td>
 		</tr>
 
-		<tr style="display:none" name="phone_num" id="phone_num">
+		<tr style="display:none" id="phone_num">
 			<td width="22%" valign="top" class="vncell"><?= gettext("Phone Number"); ?></td>
 			<td width="78%" class="vtable">
 				<input name="phone" type="text" class="formfld unknown" id="phone" size="40" value="<?=htmlspecialchars($pconfig['phone']);?>" />
 				<br/><span class="vexpl"><?= gettext("Note: Typically *99# for GSM networks and #777 for CDMA networks"); ?></span>
 			</td>
 		</tr>
-		<tr style="display:none" name="apn_" id="apn_">
+		<tr style="display:none" id="apn_">
 			<td width="22%" valign="top" class="vncell"><?= gettext("Access Point Name (APN)"); ?></td>
 			<td width="78%" class="vtable">
 				<input name="apn" type="text" class="formfld unknown" id="apn" size="40" value="<?=htmlspecialchars($pconfig['apn']);?>" />
 			</td>
 		</tr>
 		
-		<tr style="display:none" name="ppp" id="ppp">
+		<tr style="display:none" id="ppp">
 			<td colspan="2" style="padding:0px;">
 				<table width="100%" border="0" cellpadding="6" cellspacing="0" summary="advanced">		
-					<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+					<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 						<td width="22%" valign="top" class="vncell"><?= gettext("APN number (optional)"); ?></td>
 						<td width="78%" class="vtable">
 							<input name="apnum" type="text" class="formfld unknown" id="apnum" size="2" value="<?=htmlspecialchars($pconfig['apnum']);?>" />
 							<br/><span class="vexpl"><?= gettext("Note: Defaults to 1 if you set APN above. Ignored if you set no APN above."); ?></span>
 						</td>
 					</tr>
-					<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+					<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 						<td width="22%" valign="top" class="vncell"><?= gettext("SIM PIN"); ?></td>
 						<td width="78%" class="vtable">
 							<input name="simpin" type="text" class="formfld unknown" id="simpin" size="12" value="<?=htmlspecialchars($pconfig['simpin']);?>" />
 						</td>
 					</tr>
 			
-					<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+					<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 						<td width="22%" valign="top" class="vncell"><?= gettext("SIM PIN wait"); ?></td>
 						<td width="78%" class="vtable">
 							<input name="pin-wait" type="text" class="formfld unknown" id="pin-wait" size="2" value="<?=htmlspecialchars($pconfig['pin-wait']);?>" />
 							<br/><span class="vexpl"><?= gettext("Note: Time to wait for SIM to discover network after PIN is sent to SIM (seconds)."); ?></span>
 						</td>
 					</tr>
-					<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+					<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 						<td width="22%" valign="top" class="vncell"><?= gettext("Init String"); ?></td>
 						<td width="78%" class="vtable">
 							<input type="text" size="40" class="formfld unknown" id="initstr" name="initstr" value="<?=htmlspecialchars($pconfig['initstr']);?>" />
@@ -571,14 +571,14 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 							" string at the beginning of the command. Many modern USB 3G modems don't need an initialization string."); ?></span>
 						</td>
 					</tr>
-					<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+					<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 						<td width="22%" valign="top" class="vncell"><?= gettext("Connection Timeout"); ?></td>
 						<td width="78%" class="vtable">
 							<input name="connect-timeout" type="text" class="formfld unknown" id="connect-timeout" size="2" value="<?=htmlspecialchars($pconfig['connect-timeout']);?>" />
 							<br/><span class="vexpl"><?= gettext("Note: Enter timeout in seconds for connection to be established (sec.) Default is 45 sec."); ?></span>
 						</td>
 					</tr>
-					<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+					<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 						<td valign="top" class="vncell"><?= gettext("Uptime Logging"); ?></td>
 						<td class="vtable">
 							<input type="checkbox" value="on" id="uptime" name="uptime" <?php if (isset($pconfig['uptime'])) echo "checked=\"checked\""; ?> /> <?= gettext("Enable persistent logging of connection uptime."); ?> 
@@ -588,7 +588,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				</table>
 			</td>
 		</tr>
-		<tr style="display:none" name="pppoe" id="pppoe">
+		<tr style="display:none" id="pppoe">
 			<td colspan="2" style="padding:0px;">
 				<table width="100%" border="0" cellpadding="6" cellspacing="0" summary="service name">
 					<tr>
@@ -598,7 +598,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 							<br/> <span class="vexpl"><?= gettext("Hint: this field can usually be left empty. Service name will not be configured if this field is empty. Check the \"Configure NULL\" box to configure a blank Service name."); ?></span>
 						</td>
 					</tr>
-					<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+					<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 						<td width="22%" valign="top" class="vncell"><?=gettext("Periodic reset");?></td>
 						<td width="78%" class="vtable">
 							<table id="presetwrap" cellspacing="0" cellpadding="0" width="100%" summary="periodic reset">
@@ -674,13 +674,13 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 			</td>
 		</tr><?php endfor; ?>
 
-		<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+		<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 			<td colspan="2" valign="top" height="16"></td>
 		</tr>
-		<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+		<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 			<td colspan="2" valign="top" class="listtopic"><?= gettext("Advanced Options"); ?></td>
 		</tr>
-		<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+		<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 		<td valign="top" class="vncell"><?= gettext("Dial On Demand"); ?></td>
 			<td class="vtable">
 				<input type="checkbox" value="on" id="ondemand" name="ondemand" <?php if (isset($pconfig['ondemand'])) echo "checked=\"checked\""; ?> /> <?= gettext("Enable Dial-on-Demand mode"); ?> 
@@ -688,7 +688,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				"The interface is configured, but the actual connection of the link is delayed until qualifying outgoing traffic is detected."); ?> </span>
 			</td>
 		</tr>
-		<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+		<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 			<td valign="top" class="vncell"><?= gettext("Idle Timeout"); ?></td>
 			<td class="vtable">
 				<input name="idletimeout" type="text" class="formfld unknown" id="idletimeout" size="12" value="<?=htmlspecialchars($pconfig['idletimeout']);?>" /> <?= gettext("(seconds) Default is 0, which disables the timeout feature."); ?>
@@ -696,7 +696,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				<br/><?=gettext("When the idle timeout occurs, if the dial-on-demand option is enabled, mpd goes back into dial-on-demand mode. Otherwise, the interface is brought down and all associated routes removed."); ?></span>
 			</td>
 		</tr>
-		<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+		<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 			<td width="22%" valign="top" class="vncell"><?= gettext("Compression"); ?></td>
 			<td width="78%" class="vtable">
 				<input type="checkbox" value="on" id="vjcomp" name="vjcomp" <?php if (isset($pconfig['vjcomp'])) echo "checked=\"checked\""; ?> />&nbsp;<?= gettext("Disable vjcomp(compression) (auto-negotiated by default)."); ?>
@@ -705,7 +705,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				"stamping or SACK, which modify TCP options between sequential packets.");?></span>
 			</td>
 		</tr>
-		<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+		<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 			<td width="22%" valign="top" class="vncell"><?= gettext("TCPmssFix"); ?></td>
 			<td width="78%" class="vtable">
 				<input type="checkbox" value="on" id="tcpmssfix" name="tcpmssfix" <?php if (isset($pconfig['tcpmssfix'])) echo "checked=\"checked\""; ?> />&nbsp;<?= gettext("Disable tcpmssfix (enabled by default)."); ?>
@@ -716,7 +716,7 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				"gets to discover that it must reduce the fragment size or drop the IP Don't Fragment option from its outgoing data.");?></span>
 			</td>
 		</tr>
-		<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+		<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 			<td width="22%" valign="top" class="vncell"><?=gettext("ShortSeq");?></td>
 			<td width="78%" class="vtable">
 				<input type="checkbox" value="on" id="shortseq" name="shortseq" <?php if (isset($pconfig['shortseq'])) echo "checked=\"checked\""; ?> />&nbsp;<?= gettext("Disable shortseq (auto-negotiated by default)."); ?>
@@ -724,35 +724,35 @@ $types = array("select" => gettext("Select"), "ppp" => "PPP", "pppoe" => "PPPoE"
 				"It is not necessary to disable this for connections that are not multi-link."); ?></span>
 			</td>
 		</tr>
-		<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+		<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 			<td width="22%" valign="top" class="vncell"><?=gettext("ACFComp"); ?></td>
 			<td width="78%" class="vtable">
 				<input type="checkbox" value="on" id="acfcomp" name="acfcomp" <?php if (isset($pconfig['acfcomp'])) echo "checked=\"checked\""; ?> />&nbsp;<?= gettext("Disable acfcomp (compression) (auto-negotiated by default)."); ?>
 				<br/> <span class="vexpl"><?= gettext("Address and control field compression. This option only applies to asynchronous link types. It saves two bytes per frame."); ?></span>
 			</td>
 		</tr>
-		<tr style="display:none" id="advanced_<?=$k;?>" name="advanced_<?=$k;$k++;?>">
+		<tr style="display:none" id="advanced_<?=$k;?>" <?$k++;?>>
 			<td width="22%" valign="top" class="vncell"><?=gettext("ProtoComp"); ?></td>
 			<td width="78%" class="vtable">
 				<input type="checkbox" value="on" id="protocomp" name="protocomp" <?php if (isset($pconfig['protocomp'])) echo "checked=\"checked\""; ?> />&nbsp;<?= gettext("Disable protocomp (compression) (auto-negotiated by default)."); ?>
 				<br/> <span class="vexpl"><?= gettext("Protocol field compression. This option saves one byte per frame for most frames."); ?></span>
 			</td>
 		</tr>
-		<tr id="advanced_" name="advanced_">
+		<tr id="advanced_">
 			<td>&nbsp;</td>
 			<td>
 			<p><input type="button" onclick="show_advanced(1)" value="<?=gettext("Show advanced options"); ?>" /></p>
 			</td>
-			<td style="display:none" id="adv_rows" name="adv_rows"><?=$k;?></td>
-			<td style="display:none" id="adv_show" name="adv_show">0</td>
+			<td style="display:none" id="adv_rows"><?=$k;?></td>
+			<td style="display:none" id="adv_show">0</td>
 		</tr>
 		<?php for($i=0; $i < $port_count; $i++) : ?>
 		<tr style="display:none" id="link<?=$i;?>">
 			<td width="22%" valign="top" id="linklabel<?=$i;?>" class="vncell"> <?=gettext("Link Parameters");?></td>
 			<td class="vtable">
-				<table name="link_parameters" border="0" cellpadding="6" cellspacing="0" summary="link parameters">
+				<table border="0" cellpadding="6" cellspacing="0" summary="link parameters">
 					<tr>
-						<td width="22%" id="bwlabel<?=$i;?>" valign="top"class="vncell"> <?=gettext("Bandwidth");?></td>
+						<td width="22%" id="bwlabel<?=$i;?>" valign="top" class="vncell"> <?=gettext("Bandwidth");?></td>
 						<td width="78%" class="vtable">
 						<br/><input name="bandwidth[]" id="bandwidth<?=$i;?>" type="text" class="formfld unknown" size="40" value="<?=htmlspecialchars($pconfig['bandwidth'][$i]);?>" />
 						<br/> <span class="vexpl"><?=gettext("Set ONLY for MLPPP connections and ONLY when links have different bandwidths.");?></span>
diff --git a/usr/local/www/javascript/interfaces_ppps_edit/ppps_edit.js b/usr/local/www/javascript/interfaces_ppps_edit/ppps_edit.js
index ff6d768..71a29cf 100644
--- a/usr/local/www/javascript/interfaces_ppps_edit/ppps_edit.js
+++ b/usr/local/www/javascript/interfaces_ppps_edit/ppps_edit.js
@@ -164,7 +164,7 @@ function show_reset_settings(reset_type) {
 
 function country_list() {
 	jQuery('#country option').remove();
-	jQuery('#provider option').remove();
+	jQuery('#provider_list option').remove();
 	jQuery('#providerplan option').remove();
 	jQuery('#country').append(new Option('', ''));
 	jQuery.ajax("getserviceproviders.php",{
@@ -185,9 +185,9 @@ function country_list() {
 }
 
 function providers_list() {
-	jQuery('#provider option').remove();
+	jQuery('#provider_list option').remove();
 	jQuery('#providerplan option').remove();
-	jQuery('#provider').append(new Option('', ''));
+	jQuery('#provider_list').append(new Option('', ''));
 	jQuery.ajax("getserviceproviders.php",{
 		type: 'POST',
 		data: {country : jQuery('#country').val()},
@@ -198,7 +198,7 @@ function providers_list() {
 			for (i = 0; i < responseTextArr.length; i += 1) {
 				value = responseTextArr[i];
 				if (/\S/.test(value)) {
-					jQuery('#provider').append(new Option(value, value));
+					jQuery('#provider_list').append(new Option(value, value));
 				}
 			}
 		}
@@ -212,7 +212,7 @@ function providerplan_list() {
 	jQuery('#providerplan').append( new Option('','') );
 	jQuery.ajax("getserviceproviders.php",{
 		type: 'POST',
-		data: {country : jQuery('#country').val(), provider : jQuery('#provider').val()},
+		data: {country : jQuery('#country').val(), provider : jQuery('#provider_list').val()},
 		success: function(responseText) {
 			var responseTextArr = responseText.split("\n");
 			var value, providerplan, i;
@@ -233,7 +233,7 @@ function providerplan_list() {
 function prefill_provider() {
 	jQuery.ajax("getserviceproviders.php",{
 		type: "POST",
-		data: {country : jQuery('#country').val(), provider : jQuery('#provider').val(), plan : jQuery('#providerplan').val()},
+		data: {country : jQuery('#country').val(), provider : jQuery('#provider_list').val(), plan : jQuery('#providerplan').val()},
 		success: function(responseXML) {
 			var xmldoc = responseXML;
 			var provider = xmldoc.getElementsByTagName('connection')[0];