summaryrefslogtreecommitdiffstats
path: root/usr/local
diff options
context:
space:
mode:
authorPhil Davis <phil.davis@inf.org>2015-01-11 20:54:31 +0545
committerChris Buechler <cmb@pfsense.org>2015-01-11 19:16:11 -0600
commit4fc1c68f14a5725194240572b75e94d2762a2558 (patch)
tree51250eba9d16ea5b7eff91a16297cc0f615fff53 /usr/local
parent7025c4fa7a2f9db516c366b3aa25ae8b849a6920 (diff)
downloadpfsense-4fc1c68f14a5725194240572b75e94d2762a2558.zip
pfsense-4fc1c68f14a5725194240572b75e94d2762a2558.tar.gz
Do not return disabled dynamic gateways
When a dynamic gateway is disabled (by the user through the webGUI), it was still being returned by return_gateways_array(). But when called like that, disabled gateways should not be returned. The first part of the routine was correctly skipping disabled gateways, but then the later part would effectively re-generate those dynamic gateways on-the-fly and not realise they should be skipped because they were disabled. This code now remembers gateway details of all the gateways, including skipped ones, so the dynamic gateway code can easily realise all gateways that have been already processed, even those that were processed and skipped. Forum: https://forum.pfsense.org/index.php?topic=86565.0 It fixes Gateway Status Widget - now if a dynamic gateway is disabled, it does not appear on the display. This will also stop disabled dynamic gateways from being returned to other callers. So there may/will be impacts on other parts of the system when a user disables a dynamic gateway. e.g. filter.inc - a gateway that has been disabled by a user canot be used in rules any more.
Diffstat (limited to 'usr/local')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud