summaryrefslogtreecommitdiffstats
path: root/usr/local/www
diff options
context:
space:
mode:
authorPhil Davis <phil.davis@inf.org>2015-06-16 22:40:23 +0545
committerPhil Davis <phil.davis@inf.org>2015-06-16 22:40:23 +0545
commit84a2e91548687baab9c53b2d03cee65af95bf3a1 (patch)
tree4608b2f3c185ce398b4633ad89cd2ae530221ebd /usr/local/www
parentab2fd59d63e0ae90da1ab47a844f1b628f2d0709 (diff)
downloadpfsense-84a2e91548687baab9c53b2d03cee65af95bf3a1.zip
pfsense-84a2e91548687baab9c53b2d03cee65af95bf3a1.tar.gz
Why is break missing for reinstallxml
I thought that "reinstallxml" should do less than "reinstallpkg" but actually it was getting stuff here, then falling through "reinstalpkg" which did delete_package_xml and then install_pkg, which got the files a 2nd time and... Maybe that was supposed to happen? Anyway, I thought I would point this out and someone can either commit this pull request if the "break" should be there, or explain to me why "reinstallxml" is supposed to fall through executing all this code.
Diffstat (limited to 'usr/local/www')
-rw-r--r--usr/local/www/pkg_mgr_install.php1
1 files changed, 1 insertions, 0 deletions
diff --git a/usr/local/www/pkg_mgr_install.php b/usr/local/www/pkg_mgr_install.php
index 8a57555..9f52f9e 100644
--- a/usr/local/www/pkg_mgr_install.php
+++ b/usr/local/www/pkg_mgr_install.php
@@ -238,6 +238,7 @@ if ($_GET) {
case 'reinstallxml':
pkg_fetch_config_file($pkgid);
pkg_fetch_additional_files($pkgid);
+ break;
case 'reinstallpkg':
delete_package_xml($pkgid);
if (install_package($pkgid) < 0) {
OpenPOWER on IntegriCloud