diff options
| author | Phil Davis <phil.davis@inf.org> | 2015-06-16 22:40:23 +0545 |
|---|---|---|
| committer | Renato Botelho <garga@FreeBSD.org> | 2015-06-16 12:40:44 -0500 |
| commit | 4fabdca76a3f956df4363d7599cfa784848506ab (patch) | |
| tree | 207c795973ba49d83189aa50abe86f5f6290e99b /usr/local/www | |
| parent | e9885763437635426f1a8a563af74467f29f329a (diff) | |
| download | pfsense-4fabdca76a3f956df4363d7599cfa784848506ab.zip pfsense-4fabdca76a3f956df4363d7599cfa784848506ab.tar.gz | |
Why is break missing for reinstallxml
I thought that "reinstallxml" should do less than "reinstallpkg" but actually it was getting stuff here, then falling through "reinstalpkg" which did delete_package_xml and then install_pkg, which got the files a 2nd time and...
Maybe that was supposed to happen?
Anyway, I thought I would point this out and someone can either commit this pull request if the "break" should be there, or explain to me why "reinstallxml" is supposed to fall through executing all this code.
Diffstat (limited to 'usr/local/www')
| -rw-r--r-- | usr/local/www/pkg_mgr_install.php | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/usr/local/www/pkg_mgr_install.php b/usr/local/www/pkg_mgr_install.php index 9c5b8b2..2d61051 100644 --- a/usr/local/www/pkg_mgr_install.php +++ b/usr/local/www/pkg_mgr_install.php @@ -230,6 +230,7 @@ if ($_GET) { case 'reinstallxml': pkg_fetch_config_file($pkgid); pkg_fetch_additional_files($pkgid); + break; case 'reinstallpkg': delete_package_xml($pkgid); if (install_package($pkgid) < 0) { |
