When Enable Static ARP entries is enabled, do not allow entries that lack an ip address from being added. Currently we do not have any type of dhcp server hooks to automatically add the arp address to the arp table to make this work otherwise.

1 files changed, 7 insertions, 1 deletions

diff --git a/usr/local/www/services_dhcp_edit.php b/usr/local/www/services_dhcp_edit.php
index df63e09..370b9b6 100755
--- a/usr/local/www/services_dhcp_edit.php
+++ b/usr/local/www/services_dhcp_edit.php
@@ -43,6 +43,9 @@ if (!$if) {
 if (!is_array($config['dhcpd'][$if]['staticmap'])) {
 	$config['dhcpd'][$if]['staticmap'] = array();
 }
+
+$static_map_enabled=isset($config['dhcpd'][$if]['staticarp']);
+
 staticmaps_sort($if);
 $a_maps = &$config['dhcpd'][$if]['staticmap'];
 $ifcfg = &$config['interfaces'][$if];
@@ -85,7 +88,10 @@ if ($_POST) {
 	if (($_POST['mac'] && !is_macaddr($_POST['mac']))) {
 		$input_errors[] = "A valid MAC address must be specified.";
 	}
-
+	if($static_map_enabled && !$_POST['ipaddr']) {
+		$input_errors[] = "Static map is enabled.  You must specify an IP address.";
+	}
+	
 	/* check for overlaps */
 	foreach ($a_maps as $mapent) {
 		if (isset($id) && ($a_maps[$id]) && ($a_maps[$id] === $mapent))