diff options
author | Phil Davis <phil.davis@inf.org> | 2015-06-23 13:13:07 +0545 |
---|---|---|
committer | Phil Davis <phil.davis@inf.org> | 2015-06-23 13:13:07 +0545 |
commit | 9a3ec939f939cb350a549dca1510c12988398ccc (patch) | |
tree | 27191db2c8be29b351a35cb80e58b1685aa0c54d /usr/local/www/widgets/widgets/rss.widget.php | |
parent | 9a8a5e6a6665c36d85a2c209b29bf0f30d701e63 (diff) | |
download | pfsense-9a3ec939f939cb350a549dca1510c12988398ccc.zip pfsense-9a3ec939f939cb350a549dca1510c12988398ccc.tar.gz |
Standardize widget iform and submit names
The log and picture widgets were both using "iforma" and "submita".
Actually it did not break anything because it was only the form name
repeated, not id. And nothing was using these names.
Traffic Graphs widget was using just "iform". That is a bit dangerous
for the future. I got tricked when cut-pasting some code to make some
settings options for the Gateways widget. I kept "iform" and then
wondered for a while why my Traffic Graphs widget show-hide settings
would not save. There was traffic graph JS that referred to just "iform"
and that started modifying the "iform" in my new Gateways widget code.
Rather than having names "iforma", "iformb"... "submita", "submitb"...
it seems much less risk of accidental duplication if these are named
like:
name_of_widget_iform
name_of_widget_submit
I don't think there is any user-visible bug in 2.2.* - so this
standardization could just go into 2.3
Diffstat (limited to 'usr/local/www/widgets/widgets/rss.widget.php')
-rw-r--r-- | usr/local/www/widgets/widgets/rss.widget.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr/local/www/widgets/widgets/rss.widget.php b/usr/local/www/widgets/widgets/rss.widget.php index cfe77a3..0850039 100644 --- a/usr/local/www/widgets/widgets/rss.widget.php +++ b/usr/local/www/widgets/widgets/rss.widget.php @@ -89,7 +89,7 @@ if ($config['widgets']['rssfeed']) { <input type="hidden" id="rss-config" name="rss-config" value="" /> <div id="rss-settings" class="widgetconfigdiv" style="display:none;"> - <form action="/widgets/widgets/rss.widget.php" method="post" name="iformc"> + <form action="/widgets/widgets/rss.widget.php" method="post" name="rss_widget_iform"> <textarea name="rssfeed" class="formfld unknown textarea_widget" id="rssfeed" cols="40" rows="3"><?=$textarea_txt;?></textarea> <br /> <table summary="rss widget"> @@ -143,7 +143,7 @@ if ($config['widgets']['rssfeed']) { </td> <td> - <input id="submitc" name="submitc" type="submit" class="formbtn" value="Save" /> + <input id="rss_widget_submit" name="rss_widget_submit" type="submit" class="formbtn" value="Save" /> </td> </tr> </table> |