diff options
author | Renato Botelho <garga@FreeBSD.org> | 2014-03-12 11:35:57 -0300 |
---|---|---|
committer | Renato Botelho <garga@FreeBSD.org> | 2014-03-12 11:42:32 -0300 |
commit | 0e6cf71b17cc57c40aebc64359c1a27e2515b7b7 (patch) | |
tree | 8e409a77838a21da4644e4d3f39d05acf17a4952 /usr/local/www/services_captiveportal_ip_edit.php | |
parent | 3b77ba4a2a96a388682d564c3b9b7517bbbfdb21 (diff) | |
download | pfsense-0e6cf71b17cc57c40aebc64359c1a27e2515b7b7.zip pfsense-0e6cf71b17cc57c40aebc64359c1a27e2515b7b7.tar.gz |
Improve checks for params 'id', 'dup' and other similar ones to make sure they are numeric integer, also, pass them through htmlspecialchars() before print
Diffstat (limited to 'usr/local/www/services_captiveportal_ip_edit.php')
-rwxr-xr-x | usr/local/www/services_captiveportal_ip_edit.php | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/usr/local/www/services_captiveportal_ip_edit.php b/usr/local/www/services_captiveportal_ip_edit.php index f16532c..7473fc3 100755 --- a/usr/local/www/services_captiveportal_ip_edit.php +++ b/usr/local/www/services_captiveportal_ip_edit.php @@ -73,8 +73,9 @@ if (!is_array($config['captiveportal'])) $config['captiveportal'] = array(); $a_cp =& $config['captiveportal']; -$id = $_GET['id']; -if (isset($_POST['id'])) +if (is_numericint($_GET['id'])) + $id = $_GET['id']; +if (isset($_POST['id']) && is_numericint($_POST['id'])) $id = $_POST['id']; if (!is_array($config['captiveportal'][$cpzone]['allowedip'])) |