If a gateway is being used by the load balancer pool, do not allow operator to reassign the gateway ip to an interface. This creates a route loop and is bad. Ticket #1039

1 files changed, 15 insertions, 0 deletions

diff --git a/usr/local/www/interfaces_opt.php b/usr/local/www/interfaces_opt.php
index 626ccd0..1233085 100755
--- a/usr/local/www/interfaces_opt.php
+++ b/usr/local/www/interfaces_opt.php
@@ -85,6 +85,21 @@ if ($_POST) {
 
 	$pconfig = $_POST;
 
+	if($_POST['gateway']) {
+		/* enumerate slbd gateways and make sure we are not creating a route loop */
+		if(is_array($config['load_balancer']['lbpool'])) {
+			foreach($config['load_balancer']['lbpool'] as $lbpool) {
+				if($lbpool['type'] == "gateway") {
+				    foreach ((array) $lbpool['servers'] as $server) {
+			            $svr = split("\|", $server);
+			            if($svr[1] == $_POST['gateway']) 
+			            		$intput_errors[] = "Cannot change {$svr[1]} gateway.  It is currently referenced by the load balancer pools.";
+					}
+				}
+			}	
+		}
+	}
+
 	/* input validation */
 	if ($_POST['enable']) {