remove /31 from interface IP assignment screens since a /31 subnet has 0 usable IP addresses. simpify all 1-32 loops by using the same code as much as possible.

1 files changed, 9 insertions, 5 deletions

diff --git a/usr/local/www/interfaces_lan.php b/usr/local/www/interfaces_lan.php
index e15fa3d..cb38e46 100755
--- a/usr/local/www/interfaces_lan.php
+++ b/usr/local/www/interfaces_lan.php
@@ -143,11 +143,15 @@ function ipaddr_change() {
                     <input name="ipaddr" type="text" class="formfld" id="hostname" size="20" value="<?=htmlspecialchars($pconfig['ipaddr']);?>" onchange="ipaddr_change()">
                     /
                     <select name="subnet" class="formfld" id="subnet">
-                      <?php for ($i = 32; $i > 0; $i--): ?>
-                      <option value="<?=$i;?>" <?php if ($i == $pconfig['subnet']) echo "selected"; ?>>
-                      <?=$i;?>
-                      </option>
-                      <?php endfor; ?>
+					<?php
+					for ($i = 32; $i > 0; $i--) {
+						if($i <> 31) {
+							echo "<option value=\"{$i}\" ";
+							if ($i == $pconfig['subnet']) echo "selected";
+							echo ">" . $i . "</option>";
+						}
+					}
+					?>
                     </select></td>
                 </tr>
 				<?php /* Wireless interface? */