diff options
author | Renato Botelho <garga@FreeBSD.org> | 2014-02-04 12:33:29 -0200 |
---|---|---|
committer | Renato Botelho <garga@FreeBSD.org> | 2014-02-04 12:47:20 -0200 |
commit | 1eb03024fe15fcd8cdd20f32a9ba7c7f1fb75821 (patch) | |
tree | 6c5186c0184447c633776c795c3f10553e3c3876 /usr/local/www/guiconfig.inc | |
parent | 46b12609e51b9b3113abc9c22a1b0ad5a2b37d11 (diff) | |
download | pfsense-1eb03024fe15fcd8cdd20f32a9ba7c7f1fb75821.zip pfsense-1eb03024fe15fcd8cdd20f32a9ba7c7f1fb75821.tar.gz |
Add escapeshellarg() calls on exec parameters. While I'm here, replace some exec() calls by php functions like symlink, copy, unlink, mkdir
Conflicts:
usr/local/www/diag_logs_vpn.php
usr/local/www/firewall_aliases_edit.php
usr/local/www/guiconfig.inc
Diffstat (limited to 'usr/local/www/guiconfig.inc')
-rwxr-xr-x | usr/local/www/guiconfig.inc | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/usr/local/www/guiconfig.inc b/usr/local/www/guiconfig.inc index 454e02a..daf5173 100755 --- a/usr/local/www/guiconfig.inc +++ b/usr/local/www/guiconfig.inc @@ -551,9 +551,9 @@ function clear_log_file($logfile = "/var/log/system.log") { touch($logfile); } else { if(isset($config['system']['usefifolog'])) - exec("/usr/sbin/fifolog_create -s 511488 {$logfile}"); + exec("/usr/sbin/fifolog_create -s 511488 " . escapeshellarg($logfile)); else - exec("/usr/sbin/clog -i -s 511488 {$logfile}"); + exec("/usr/sbin/clog -i -s 511488 " . escapeshellarg($logfile)); } system_syslogd_start(); } @@ -565,20 +565,20 @@ function dump_clog($logfile, $tail, $withorig = true, $grepfor = "", $grepinvert $grepline = " "; if(is_array($grepfor)) foreach($grepfor as $agrep) - $grepline .= " | grep \"$agrep\""; + $grepline .= " | grep " . escapeshellarg($agrep); if(is_array($grepinvert)) foreach($grepinvert as $agrep) - $grepline .= " | grep -v \"$agrep\""; + $grepline .= " | grep -v " . escapeshellarg($agrep); if(file_exists($logfile) && filesize($logfile) == 0) { $logarr = array("Log file started."); } else { if($config['system']['disablesyslogclog']) { - exec("cat {$logfile}{$grepline} | /usr/bin/tail {$sor} -n {$tail}", $logarr); + exec("cat " . escapeshellarg($logfile) . "{$grepline} | /usr/bin/tail {$sor} -n " . escapeshellarg($tail), $logarr); } else { if(isset($config['system']['usefifolog'])) - exec("/usr/sbin/fifolog_reader {$logfile}{$grepline} | /usr/bin/tail {$sor} -n {$tail}", $logarr); + exec("/usr/sbin/fifolog_reader " . escapeshellarg($logfile) . "{$grepline} | /usr/bin/tail {$sor} -n " . escapeshellarg($tail), $logarr); else - exec("/usr/sbin/clog {$logfile}{$grepline}| grep -v \"CLOG\" | grep -v \"\033\" | /usr/bin/tail {$sor} -n {$tail}", $logarr); + exec("/usr/sbin/clog " . escapeshellarg($logfile) . "{$grepline}| grep -v \"CLOG\" | grep -v \"\033\" | /usr/bin/tail {$sor} -n " . escapeshellarg($tail), $logarr); } } foreach ($logarr as $logent) { @@ -610,17 +610,17 @@ function return_clog($logfile, $tail, $withorig = true, $grepfor = "", $grepinve $grepline = " "; if(is_array($grepfor)) foreach($grepfor as $agrep) - $grepline .= " | grep \"$agrep\""; + $grepline .= " | grep " . escapeshellarg($agrep); if(is_array($grepinvert)) foreach($grepinvert as $agrep) - $grepline .= " | grep -v \"$agrep\""; + $grepline .= " | grep -v " . escapeshellarg($agrep); if($config['system']['disablesyslogclog']) { - exec("cat {$logfile}{$grepline} | /usr/bin/tail {$sor} -n {$tail}", $logarr); + exec("cat " . escapeshellarg($logfile) . "{$grepline} | /usr/bin/tail {$sor} -n " . escapeshellarg($tail), $logarr); } else { if(isset($config['system']['usefifolog'])) { - exec("/usr/sbin/fifolog_reader {$logfile}{$grepline} | /usr/bin/tail {$sor} -n {$tail}", $logarr); + exec("/usr/sbin/fifolog_reader " . escapeshellarg($logfile) . "{$grepline} | /usr/bin/tail {$sor} -n " . escapeshellarg($tail), $logarr); } else { - exec("/usr/sbin/clog {$logfile}{$grepline}| grep -v \"CLOG\" | grep -v \"\033\" | /usr/bin/tail {$sor} -n {$tail}", $logarr); + exec("/usr/sbin/clog " . escapeshellarg($logfile) . "{$grepline}| grep -v \"CLOG\" | grep -v \"\033\" | /usr/bin/tail {$sor} -n " . escapeshellarg($tail), $logarr); } } return($logarr); |