summaryrefslogtreecommitdiffstats
path: root/usr/local/www/favicon.ico
diff options
context:
space:
mode:
authorPhil Davis <phil.davis@inf.org>2015-07-17 23:05:06 +0545
committerRenato Botelho <renato@netgate.com>2015-07-18 12:58:34 -0300
commit49fc1967c6f754cb39995893cf64b9a1d3c063f1 (patch)
tree86b4c5084557ac982fbb2c10e69161a2f8ccce66 /usr/local/www/favicon.ico
parent642e925fa19b33a3fce2015dd869433c885b1d07 (diff)
downloadpfsense-49fc1967c6f754cb39995893cf64b9a1d3c063f1.zip
pfsense-49fc1967c6f754cb39995893cf64b9a1d3c063f1.tar.gz
Really avoid error loading rules for numeric host name in alias
Create a host-type alias. Put just a number in "IP or FQDN" - e.g. I made alias name "Zqw" and a single host "23". The webGUI reports: There were error(s) loading the rules: /tmp/rules.debug:44: syntax error - The line in question reads [44]: table { 23 } and /tmp/rules.debug has: table { 23 } Zqw = "" which pf does not cope with. This change will differentiate between a number in the context of a port alias and a number that is_hostname. This time I think it really works :) The call to alias_get_type() needed to send the alias name as parameter. alias_get_type() is a bit expensive - it scans through the whole list of aliases looking for a match on the name. So I made this code just call it once for the name and then use that $alias_type var each time as it loops through all the addresses in an alias. I have tried this successfully with a few combinations of nested port/host/network aliases. But maybe there is some wacky combination of nested aliases possible that could still break this? I don't see how, but it needs testing on some configs that have all sorts of nested alias types.
Diffstat (limited to 'usr/local/www/favicon.ico')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud