diff options
| author | Phil Davis <phil.davis@inf.org> | 2017-01-01 11:01:38 +0545 |
|---|---|---|
| committer | Renato Botelho <renato@netgate.com> | 2017-01-02 08:45:42 -0200 |
| commit | b961bc234c9c8fc7c368442e36385ca3f85feba7 (patch) | |
| tree | 7dc96a27744e6fa6e3e86d11238e03d5c97401df /src | |
| parent | c603ead77bdf6aa573e021366372571a56ebac44 (diff) | |
| download | pfsense-b961bc234c9c8fc7c368442e36385ca3f85feba7.zip pfsense-b961bc234c9c8fc7c368442e36385ca3f85feba7.tar.gz | |
Remove redundant gettext() in firewall_rules_edit
The 'helpmsg' here is already translated with gettext() when the 'helpmsg' array entries are set up, so IMHO there is no need to attempt translation again.
(cherry picked from commit cffe1271c962ac9159c43fd214c735ceb4b5e1b8)
Diffstat (limited to 'src')
| -rw-r--r-- | src/usr/local/www/firewall_rules_edit.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/usr/local/www/firewall_rules_edit.php b/src/usr/local/www/firewall_rules_edit.php index c95402b..f37ecc2 100644 --- a/src/usr/local/www/firewall_rules_edit.php +++ b/src/usr/local/www/firewall_rules_edit.php @@ -1325,7 +1325,7 @@ $group->add(new Form_Select( ((isset($pconfig['icmptype']) && strlen($pconfig['icmptype']) > 0) ? explode(',', $pconfig['icmptype']) : 'any'), isset($icmplookup[$pconfig['ipprotocol']]) ? $icmplookup[$pconfig['ipprotocol']]['icmptypes'] : array('any' => gettext('any')), true -))->setHelp('<div id="icmptype_help">' . (isset($icmplookup[$pconfig['ipprotocol']]) ? gettext($icmplookup[$pconfig['ipprotocol']]['helpmsg']) : '') . '</div>'); +))->setHelp('<div id="icmptype_help">' . (isset($icmplookup[$pconfig['ipprotocol']]) ? $icmplookup[$pconfig['ipprotocol']]['helpmsg'] : '') . '</div>'); $group->addClass('icmptype_section'); $section->add($group); @@ -2000,7 +2000,7 @@ events.push(function() { $a[] = sprintf("'%s':'%s'", $icmp_k, $icmp_v); } $out1 .= "icmptypes['{$k}'] = {\n\t" . implode(",\n\t", $a) . "\n};\n"; - $out2 .= "icmphelp['{$k}'] = '" . str_replace("'", ''', gettext($v['helpmsg'])) . "';\n"; + $out2 .= "icmphelp['{$k}'] = '" . str_replace("'", ''', $v['helpmsg']) . "';\n"; } echo $out1; echo $out2; |
