summaryrefslogtreecommitdiffstats
path: root/src/usr
diff options
context:
space:
mode:
authorPhil Davis <phil.davis@inf.org>2016-01-22 22:42:28 +0545
committerStephen Beaver <sbeaver@netgate.com>2016-01-22 12:21:45 -0500
commit3b3a95e5511ef5f60f8142480ddf5adcaed88cb1 (patch)
treec011d618e1b5d6123107f4c148d15fe0a6bb87d7 /src/usr
parentbea2dd6d5fd711653565ec212d0dd62a44b7f043 (diff)
downloadpfsense-3b3a95e5511ef5f60f8142480ddf5adcaed88cb1.zip
pfsense-3b3a95e5511ef5f60f8142480ddf5adcaed88cb1.tar.gz
Fix #5794 remove print_info_box_np chackes for gettext("apply")
1) Get rid of the stristr() checks to "guess" if an apply button should be used. 2) Change print_info_box() so it can take a button name of "close" , "apply" or none to decide which button to show. 3) Delete function print_info_box_np_undo() - nothing calls it. 4) Add new function print_apply_box() to provide an easy wrapper for print_info_box() with the parameters to be 'warning' level and 'apply' button. 5) Change print_info_box_np() calls to just print_info_box() or print_apply_box() as appropriate. There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php remaining. That tries to make a "create" button. It was not working before this change. It needs to be sorted out and fixed separately. After this change there is no dependency on a string containing text like "apply" to make the apply button appear. Then we can work on re-engineering the internal code of print_info_box_np() print_info_box() and print_apply_box() to fit together however we like. It should be easy to preserving the current API to print_info_box() and print_apply_box().
Diffstat (limited to 'src/usr')
-rw-r--r--src/usr/local/www/firewall_aliases.php1
-rw-r--r--src/usr/local/www/firewall_nat.php4
-rw-r--r--src/usr/local/www/firewall_nat_1to1.php4
-rw-r--r--src/usr/local/www/firewall_nat_npt.php4
-rw-r--r--src/usr/local/www/firewall_nat_out.php4
-rw-r--r--src/usr/local/www/firewall_rules.php2
-rw-r--r--src/usr/local/www/firewall_shaper.php2
-rw-r--r--src/usr/local/www/firewall_shaper_queues.php2
-rw-r--r--src/usr/local/www/firewall_shaper_vinterface.php2
-rw-r--r--src/usr/local/www/firewall_shaper_wizards.php2
-rw-r--r--src/usr/local/www/firewall_virtual_ip.php2
-rw-r--r--src/usr/local/www/guiconfig.inc83
-rwxr-xr-xsrc/usr/local/www/head.inc2
-rw-r--r--src/usr/local/www/interfaces.php4
-rw-r--r--src/usr/local/www/interfaces_assign.php2
-rw-r--r--src/usr/local/www/load_balancer_monitor.php2
-rw-r--r--src/usr/local/www/load_balancer_pool.php2
-rw-r--r--src/usr/local/www/load_balancer_setting.php4
-rw-r--r--src/usr/local/www/load_balancer_virtual_server.php2
-rwxr-xr-xsrc/usr/local/www/pkg.php6
-rw-r--r--src/usr/local/www/pkg_edit.php2
-rw-r--r--src/usr/local/www/pkg_mgr.php2
-rw-r--r--src/usr/local/www/pkg_mgr_installed.php2
-rw-r--r--src/usr/local/www/services_captiveportal_mac.php2
-rw-r--r--src/usr/local/www/services_captiveportal_zones.php2
-rw-r--r--src/usr/local/www/services_dhcp.php2
-rw-r--r--src/usr/local/www/services_dhcpv6.php5
-rw-r--r--src/usr/local/www/services_dnsmasq.php2
-rw-r--r--src/usr/local/www/services_igmpproxy.php2
-rw-r--r--src/usr/local/www/services_pppoe.php2
-rw-r--r--src/usr/local/www/services_unbound.php2
-rw-r--r--src/usr/local/www/services_unbound_acls.php2
-rw-r--r--src/usr/local/www/services_unbound_advanced.php4
-rw-r--r--src/usr/local/www/status_lb_pool.php2
-rw-r--r--src/usr/local/www/status_queues.php2
-rw-r--r--src/usr/local/www/system_advanced_sysctl.php2
-rw-r--r--src/usr/local/www/system_gateway_groups.php2
-rw-r--r--src/usr/local/www/system_gateways.php2
-rw-r--r--src/usr/local/www/system_groupmanager_addprivs.php2
-rw-r--r--src/usr/local/www/system_routes.php2
-rw-r--r--src/usr/local/www/system_usermanager_addprivs.php2
-rw-r--r--src/usr/local/www/vpn_ipsec.php2
-rw-r--r--src/usr/local/www/vpn_ipsec_keys.php2
-rw-r--r--src/usr/local/www/vpn_ipsec_mobile.php2
-rw-r--r--src/usr/local/www/vpn_l2tp.php2
-rw-r--r--src/usr/local/www/vpn_l2tp_users.php2
-rw-r--r--src/usr/local/www/wizard.php8
-rw-r--r--src/usr/local/www/wizards/setup_wizard.xml4
48 files changed, 85 insertions, 120 deletions
diff --git a/src/usr/local/www/firewall_aliases.php b/src/usr/local/www/firewall_aliases.php
index ffecc25..cdcf135 100644
--- a/src/usr/local/www/firewall_aliases.php
+++ b/src/usr/local/www/firewall_aliases.php
@@ -204,7 +204,6 @@ if ($savemsg) {
}
if (is_subsystem_dirty('aliases')) {
- print_info_box_np(gettext("The alias list has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
}
display_top_tabs($tab_array);
diff --git a/src/usr/local/www/firewall_nat.php b/src/usr/local/www/firewall_nat.php
index 287133b..f2c8241 100644
--- a/src/usr/local/www/firewall_nat.php
+++ b/src/usr/local/www/firewall_nat.php
@@ -187,8 +187,8 @@ if ($savemsg) {
}
if (is_subsystem_dirty('natconf')) {
- print_info_box_np(gettext('The NAT configuration has been changed.') . '<br />' .
- gettext('You must apply the changes in order for them to take effect.'));
+ print_apply_box(gettext('The NAT configuration has been changed.') . '<br />' .
+ gettext('You must apply the changes in order for them to take effect.'));
}
$tab_array = array();
diff --git a/src/usr/local/www/firewall_nat_1to1.php b/src/usr/local/www/firewall_nat_1to1.php
index 3042a70..92b0a23 100644
--- a/src/usr/local/www/firewall_nat_1to1.php
+++ b/src/usr/local/www/firewall_nat_1to1.php
@@ -160,8 +160,8 @@ if ($savemsg) {
}
if (is_subsystem_dirty('natconf')) {
- print_info_box_np(gettext('The NAT configuration has been changed.') . '<br />' .
- gettext('You must apply the changes in order for them to take effect.'));
+ print_apply_box(gettext('The NAT configuration has been changed.') . '<br />' .
+ gettext('You must apply the changes in order for them to take effect.'));
}
$tab_array = array();
diff --git a/src/usr/local/www/firewall_nat_npt.php b/src/usr/local/www/firewall_nat_npt.php
index 89179ce..d57d3f0 100644
--- a/src/usr/local/www/firewall_nat_npt.php
+++ b/src/usr/local/www/firewall_nat_npt.php
@@ -160,8 +160,8 @@ if ($savemsg) {
}
if (is_subsystem_dirty('natconf')) {
- print_info_box_np(gettext('The NAT configuration has been changed.') . '<br />' .
- gettext('You must apply the changes in order for them to take effect.'));
+ print_apply_box(gettext('The NAT configuration has been changed.') . '<br />' .
+ gettext('You must apply the changes in order for them to take effect.'));
}
$tab_array = array();
diff --git a/src/usr/local/www/firewall_nat_out.php b/src/usr/local/www/firewall_nat_out.php
index cb31869..f0a66dc 100644
--- a/src/usr/local/www/firewall_nat_out.php
+++ b/src/usr/local/www/firewall_nat_out.php
@@ -244,8 +244,8 @@ if ($savemsg) {
}
if (is_subsystem_dirty('natconf')) {
- print_info_box_np(gettext('The NAT configuration has been changed.') . '<br />' .
- gettext('You must apply the changes in order for them to take effect.'));
+ print_apply_box(gettext('The NAT configuration has been changed.') . '<br />' .
+ gettext('You must apply the changes in order for them to take effect.'));
}
$tab_array = array();
diff --git a/src/usr/local/www/firewall_rules.php b/src/usr/local/www/firewall_rules.php
index 24483da..6ce03a1 100644
--- a/src/usr/local/www/firewall_rules.php
+++ b/src/usr/local/www/firewall_rules.php
@@ -277,7 +277,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('filter')) {
- print_info_box_np(gettext("The firewall rule configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."), "apply", "", true);
+ print_apply_box(gettext("The firewall rule configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
}
display_top_tabs($tab_array);
diff --git a/src/usr/local/www/firewall_shaper.php b/src/usr/local/www/firewall_shaper.php
index b10bdd2..1ac8c2d 100644
--- a/src/usr/local/www/firewall_shaper.php
+++ b/src/usr/local/www/firewall_shaper.php
@@ -430,7 +430,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('shaper')) {
- print_info_box_np(gettext("The traffic shaper configuration has been changed. You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The traffic shaper configuration has been changed. You must apply the changes in order for them to take effect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/firewall_shaper_queues.php b/src/usr/local/www/firewall_shaper_queues.php
index dfe7584..6586104 100644
--- a/src/usr/local/www/firewall_shaper_queues.php
+++ b/src/usr/local/www/firewall_shaper_queues.php
@@ -236,7 +236,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('shaper')) {
- print_info_box_np(gettext("The traffic shaper configuration has been changed. You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The traffic shaper configuration has been changed. You must apply the changes in order for them to take effect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/firewall_shaper_vinterface.php b/src/usr/local/www/firewall_shaper_vinterface.php
index 7ebe0ab..35a366f 100644
--- a/src/usr/local/www/firewall_shaper_vinterface.php
+++ b/src/usr/local/www/firewall_shaper_vinterface.php
@@ -408,7 +408,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('shaper')) {
- print_info_box_np(gettext("The traffic shaper configuration has been changed. You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The traffic shaper configuration has been changed. You must apply the changes in order for them to take effect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/firewall_shaper_wizards.php b/src/usr/local/www/firewall_shaper_wizards.php
index 7bbc941..b1e8eb2 100644
--- a/src/usr/local/www/firewall_shaper_wizards.php
+++ b/src/usr/local/www/firewall_shaper_wizards.php
@@ -119,7 +119,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('shaper')) {
- print_info_box_np(gettext("The traffic shaper configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The traffic shaper configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
}
?>
diff --git a/src/usr/local/www/firewall_virtual_ip.php b/src/usr/local/www/firewall_virtual_ip.php
index 8db4818..964ba69 100644
--- a/src/usr/local/www/firewall_virtual_ip.php
+++ b/src/usr/local/www/firewall_virtual_ip.php
@@ -276,7 +276,7 @@ if ($input_errors) {
} else if ($savemsg) {
print_info_box($savemsg, 'success');
} else if (is_subsystem_dirty('vip')) {
- print_info_box_np(gettext("The VIP configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The VIP configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
}
/* active tabs
diff --git a/src/usr/local/www/guiconfig.inc b/src/usr/local/www/guiconfig.inc
index b86a0ba..af97879 100644
--- a/src/usr/local/www/guiconfig.inc
+++ b/src/usr/local/www/guiconfig.inc
@@ -91,11 +91,6 @@ $navlevelsep = ": "; /* navigation level separator string */
$mandfldhtml = ""; /* display this before mandatory input fields */
$mandfldhtmlspc = ""; /* same as above, but with spacing */
-if (!function_exists('set_language')) {
- require_once("pfsense-utils.inc");
-}
-set_language();
-
/* Some ajax scripts still need access to GUI */
if (!$ignorefirmwarelock) {
if (is_subsystem_dirty('firmwarelock')) {
@@ -306,7 +301,7 @@ function verify_gzip_file($fname) {
}
}
-function print_info_box_np($msg, $name="apply", $value="", $showapply=false, $class="alert-warning",$showbtn = true) {
+function print_info_box_np($msg, $name="apply", $value="", $showapply=false, $class="alert-warning", $showclose = true) {
global $g;
if (strpos($class, "alert-") !== 0) {
@@ -319,10 +314,7 @@ function print_info_box_np($msg, $name="apply", $value="", $showapply=false, $cl
$msg = '<div class="pull-left">' . $msg . '</div>';
- // The $msg string might or might not have had a known translation into the target language.
- // So check it against the keywords "apply", "save and "create" in both the target language and English.
- if ((stristr($msg, gettext("apply")) != false) || (stristr($msg, gettext("save")) != false) || (stristr($msg, gettext("create")) != false) ||
- (stristr($msg, "apply") != false) || (stristr($msg, "save") != false) || (stristr($msg, "create") != false) || $showapply) {
+ if ($showapply) {
$msg .= '<form method="post" class="pull-right"><button type="submit" class="btn btn-default" name="'. $name .'" value="' . $value . '">' . $name . '</button>';
if ($_POST['if']) {
@@ -330,63 +322,36 @@ function print_info_box_np($msg, $name="apply", $value="", $showapply=false, $cl
}
$msg .= '</form>';
- } else if ($showbtn) {
+ } else if ($showclose) {
$msg = '<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>' . $msg;
}
echo '<div class="alert ' . $class . ' clearfix" role="alert">' . $msg . '</div>';
}
-function print_info_box_np_undo($msg, $name = "apply", $value = "Apply changes", $undo) {
- global $g;
-
- if (stristr($msg, "apply") != false || stristr($msg, "save") != false || stristr($msg, "create") != false) {
- $savebutton = "<td class=\"infoboxsave text-nowrap\">";
- $savebutton .= "<input type=\"button\" value=\"". gettext("Undo") . "\" onclick=\"document.location='{$undo}'\" />";
- $savebutton .= "<input name=\"{$name}\" type=\"submit\" class=\"formbtn\" id=\"${name}\" value=\"{$value}\" />";
- $savebutton .= "</td>";
- if ($_POST['if']) {
- $savebutton .= "<input type=\"hidden\" name=\"if\" value=\"" . htmlspecialchars($_POST['if']) . "\" />";
- }
- }
-
- $nifty_redbox = "#990000";
- $nifty_blackbox = "#000000";
-
- if (!$savebutton) {
- $savebutton = "<td class=\"infoboxsave\"><input value=\"" . gettext("Close") . "\" type=\"button\" onclick=\"$(this).parents('table[id=redboxtable]').hide();\" /></td>";
- }
-
- echo <<<EOFnp
- <table class="infobox" id="redboxtable" summary="red box table">
- <tr>
- <td>
- <div class="infoboxnp" id="redbox">
- <table class="infoboxnptable2" summary="message">
- <tr>
- <td class="infoboxnptd">
- &nbsp;&nbsp;&nbsp;<i class="fa fa-exclamation-circle"></i>
- </td>
- <td class="infoboxnptd2">
- <b>{$msg}</b>
- </td>
- {$savebutton}
- {$undobutton}
- </tr>
- </table>
- </div>
- <div>
- <p>&nbsp;</p>
- </div>
- </td>
- </tr>
- </table>
-EOFnp;
-
+function print_info_box($msg, $class="alert-warning", $btntoshow = "close") {
+ switch ($btntoshow) {
+ case "close":
+ $showclose = true;
+ $showapply = false;
+ $name = "";
+ break;
+ case "apply":
+ $showclose = false;
+ $showapply = true;
+ $name = "apply";
+ break;
+ default:
+ $showclose = false;
+ $showapply = false;
+ $name = "";
+ break;
+ }
+ print_info_box_np($msg, $name, null, $showapply, $class, $showclose);
}
-function print_info_box($msg, $class="alert-warning", $showbtn = true) {
- print_info_box_np($msg, null, null, false, $class, $showbtn);
+function print_apply_box($msg) {
+ print_info_box($msg, "warning", "apply");
}
function get_std_save_message($ok) {
diff --git a/src/usr/local/www/head.inc b/src/usr/local/www/head.inc
index c18461f..e2b9c9b 100755
--- a/src/usr/local/www/head.inc
+++ b/src/usr/local/www/head.inc
@@ -539,7 +539,7 @@ $pgtitle_output = true;
if ($config['remote_managed_pages']['item']) {
foreach ($config['remote_managed_pages']['item'] as $rmp) {
if ($rmp == $_SERVER['SCRIPT_NAME']) {
- print_info_box_np(gettext("This page is currently being managed by a remote machine."));
+ print_info_box(gettext("This page is currently being managed by a remote machine."));
include("foot.inc");
exit;
}
diff --git a/src/usr/local/www/interfaces.php b/src/usr/local/www/interfaces.php
index 465bf2f..73755ca 100644
--- a/src/usr/local/www/interfaces.php
+++ b/src/usr/local/www/interfaces.php
@@ -1699,8 +1699,8 @@ if ($input_errors) {
}
if (is_subsystem_dirty('interfaces')) {
- print_info_box_np(sprintf(gettext("The %s configuration has been changed."), $wancfg['descr']) . "<br />" .
- gettext("You must apply the changes in order for them to take effect. Don't forget to adjust the DHCP Server range if needed after applying."));
+ print_apply_box(sprintf(gettext("The %s configuration has been changed."), $wancfg['descr']) . "<br />" .
+ gettext("You must apply the changes in order for them to take effect. Don't forget to adjust the DHCP Server range if needed after applying."));
}
if ($savemsg) {
diff --git a/src/usr/local/www/interfaces_assign.php b/src/usr/local/www/interfaces_assign.php
index 0570d39..0494201 100644
--- a/src/usr/local/www/interfaces_assign.php
+++ b/src/usr/local/www/interfaces_assign.php
@@ -502,7 +502,7 @@ if (file_exists("/var/run/interface_mismatch_reboot_needed")) {
if (file_exists("/tmp/reload_interfaces")) {
echo "<p>\n";
- print_info_box_np(gettext("The interface configuration has been changed.<br />You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The interface configuration has been changed.<br />You must apply the changes in order for them to take effect."));
echo "<br /></p>\n";
} elseif ($savemsg) {
print_info_box($savemsg, $class);
diff --git a/src/usr/local/www/load_balancer_monitor.php b/src/usr/local/www/load_balancer_monitor.php
index 8248cf0..5f53839 100644
--- a/src/usr/local/www/load_balancer_monitor.php
+++ b/src/usr/local/www/load_balancer_monitor.php
@@ -118,7 +118,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('loadbalancer')) {
- print_info_box_np(gettext("The load balancer configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The load balancer configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
}
/* active tabs */
diff --git a/src/usr/local/www/load_balancer_pool.php b/src/usr/local/www/load_balancer_pool.php
index eac075d..be52079 100644
--- a/src/usr/local/www/load_balancer_pool.php
+++ b/src/usr/local/www/load_balancer_pool.php
@@ -132,7 +132,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('loadbalancer')) {
- print_info_box_np(sprintf(gettext("The load balancer configuration has been changed%sYou must apply the changes in order for them to take effect."), "<br />"));
+ print_apply_box(sprintf(gettext("The load balancer configuration has been changed%sYou must apply the changes in order for them to take effect."), "<br />"));
}
/* active tabs */
diff --git a/src/usr/local/www/load_balancer_setting.php b/src/usr/local/www/load_balancer_setting.php
index 57f96af..9f4bdbf 100644
--- a/src/usr/local/www/load_balancer_setting.php
+++ b/src/usr/local/www/load_balancer_setting.php
@@ -131,8 +131,8 @@ if ($savemsg) {
}
if (is_subsystem_dirty('loadbalancer')) {
- print_info_box_np(gettext("The load balancer configuration has been changed") . ' ' .
- gettext("You must apply the changes in order for them to take effect."), 'Apply', null, false, 'danger');
+ print_apply_box(gettext("The load balancer configuration has been changed") . ' ' .
+ gettext("You must apply the changes in order for them to take effect."));
}
/* active tabs */
diff --git a/src/usr/local/www/load_balancer_virtual_server.php b/src/usr/local/www/load_balancer_virtual_server.php
index 628f040..ba47ea5 100644
--- a/src/usr/local/www/load_balancer_virtual_server.php
+++ b/src/usr/local/www/load_balancer_virtual_server.php
@@ -132,7 +132,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('loadbalancer')) {
- print_info_box_np(gettext("The virtual server configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The virtual server configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
}
/* active tabs */
diff --git a/src/usr/local/www/pkg.php b/src/usr/local/www/pkg.php
index ff2203d..005495f 100755
--- a/src/usr/local/www/pkg.php
+++ b/src/usr/local/www/pkg.php
@@ -71,21 +71,21 @@ $xml = $_REQUEST['xml'];
if ($xml == "") {
include("head.inc");
- print_info_box_np(gettext("ERROR: No valid package defined."));
+ print_info_box(gettext("ERROR: No valid package defined."));
include("foot.inc");
exit;
} else {
$pkg_xml_prefix = "/usr/local/pkg/";
$pkg_full_path = "{$pkg_xml_prefix}/{$xml}";
if (substr_compare(realpath($pkg_full_path), $pkg_xml_prefix, 0, strlen($pkg_xml_prefix))) {
- print_info_box_np(gettext("ERROR: Invalid path specified."));
+ print_info_box(gettext("ERROR: Invalid path specified."));
die;
}
if (file_exists($pkg_full_path)) {
$pkg = parse_xml_config_pkg($pkg_full_path, "packagegui");
} else {
include("head.inc");
- print_info_box_np(gettext("File not found ") . htmlspecialchars($xml));
+ print_info_box(gettext("File not found ") . htmlspecialchars($xml));
include("foot.inc");
exit;
}
diff --git a/src/usr/local/www/pkg_edit.php b/src/usr/local/www/pkg_edit.php
index 81ded09..81551ec 100644
--- a/src/usr/local/www/pkg_edit.php
+++ b/src/usr/local/www/pkg_edit.php
@@ -82,7 +82,7 @@ $xml_fullpath = realpath('/usr/local/pkg/' . $xml);
if ($xml == "" || $xml_fullpath === false || substr($xml_fullpath, 0, strlen('/usr/local/pkg/')) != '/usr/local/pkg/') {
include("head.inc");
- print_info_box_np(gettext("ERROR: No valid package defined."));
+ print_info_box(gettext("ERROR: No valid package defined."));
include("foot.inc");
die;
} else {
diff --git a/src/usr/local/www/pkg_mgr.php b/src/usr/local/www/pkg_mgr.php
index 439af71..9d30f8a 100644
--- a/src/usr/local/www/pkg_mgr.php
+++ b/src/usr/local/www/pkg_mgr.php
@@ -71,7 +71,7 @@ require_once("pkg-utils.inc");
if (is_subsystem_dirty('packagelock')) {
$pgtitle = array(gettext("System"), gettext("Package Manager"));
include("head.inc");
- print_info_box_np("Please wait while packages are reinstalled in the background.");
+ print_info_box("Please wait while packages are reinstalled in the background.");
include("foot.inc");
exit;
}
diff --git a/src/usr/local/www/pkg_mgr_installed.php b/src/usr/local/www/pkg_mgr_installed.php
index 483a55e..56555f4 100644
--- a/src/usr/local/www/pkg_mgr_installed.php
+++ b/src/usr/local/www/pkg_mgr_installed.php
@@ -67,7 +67,7 @@ require_once("pkg-utils.inc");
if (is_subsystem_dirty('packagelock')) {
$pgtitle = array(gettext("System"), gettext("Package Manager"));
include("head.inc");
- print_info_box_np("Please wait while packages are reinstalled in the background.");
+ print_info_box("Please wait while packages are reinstalled in the background.");
include("foot.inc");
exit;
}
diff --git a/src/usr/local/www/services_captiveportal_mac.php b/src/usr/local/www/services_captiveportal_mac.php
index fca42ef..5b4541a 100644
--- a/src/usr/local/www/services_captiveportal_mac.php
+++ b/src/usr/local/www/services_captiveportal_mac.php
@@ -189,7 +189,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('passthrumac')) {
- print_info_box_np(gettext("The captive portal MAC address configuration has been changed.<br />You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The captive portal MAC address configuration has been changed.<br />You must apply the changes in order for them to take effect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/services_captiveportal_zones.php b/src/usr/local/www/services_captiveportal_zones.php
index 125bea4..362df39 100644
--- a/src/usr/local/www/services_captiveportal_zones.php
+++ b/src/usr/local/www/services_captiveportal_zones.php
@@ -99,7 +99,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('captiveportal')) {
- print_info_box_np(gettext("The Captive Portal entry list has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The Captive Portal entry list has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
}
?>
<form action="services_captiveportal_zones.php" method="post">
diff --git a/src/usr/local/www/services_dhcp.php b/src/usr/local/www/services_dhcp.php
index b7075ae..0b76899 100644
--- a/src/usr/local/www/services_dhcp.php
+++ b/src/usr/local/www/services_dhcp.php
@@ -713,7 +713,7 @@ if (isset($config['dhcrelay']['enable'])) {
}
if (is_subsystem_dirty('staticmaps')) {
- print_info_box_np(gettext("The static mapping configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The static mapping configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
}
/* active tabs */
diff --git a/src/usr/local/www/services_dhcpv6.php b/src/usr/local/www/services_dhcpv6.php
index 676927e..cb15605 100644
--- a/src/usr/local/www/services_dhcpv6.php
+++ b/src/usr/local/www/services_dhcpv6.php
@@ -456,7 +456,7 @@ if ($dhcrelay_enabled) {
}
if (is_subsystem_dirty('staticmaps')) {
- print_info_box_np(gettext('The static mapping configuration has been changed') . '.<br />' . gettext('You must apply the changes in order for them to take effect.'));
+ print_apply_box(gettext('The static mapping configuration has been changed') . '.<br />' . gettext('You must apply the changes in order for them to take effect.'));
}
/* active tabs */
@@ -883,7 +883,8 @@ print_info_box(gettext('The DNS servers entered in ') . '<a href="system.php">'
gettext('will be assigned to clients by the DHCP server.') . '<br />' .
gettext('The DHCP lease table can be viewed on the ') . '<a href="status_dhcpv6_leases.php">' .
gettext('Status: DHCPv6 leases') . '</a>' . gettext(' page.'),
- 'info');
+ 'info',
+ false);
?>
</div>
<div class="panel panel-default">
diff --git a/src/usr/local/www/services_dnsmasq.php b/src/usr/local/www/services_dnsmasq.php
index 72fbc50..18274b8 100644
--- a/src/usr/local/www/services_dnsmasq.php
+++ b/src/usr/local/www/services_dnsmasq.php
@@ -225,7 +225,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('hosts')) {
- print_info_box_np(gettext("The DNS forwarder configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The DNS forwarder configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
}
$form = new Form();
diff --git a/src/usr/local/www/services_igmpproxy.php b/src/usr/local/www/services_igmpproxy.php
index 4c22271..420d963 100644
--- a/src/usr/local/www/services_igmpproxy.php
+++ b/src/usr/local/www/services_igmpproxy.php
@@ -106,7 +106,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('igmpproxy')) {
- print_info_box_np(gettext('The IGMP entry list has been changed.' . '<br />' . 'You must apply the changes in order for them to take effect.'));
+ print_apply_box(gettext('The IGMP entry list has been changed.' . '<br />' . 'You must apply the changes in order for them to take effect.'));
}
?>
diff --git a/src/usr/local/www/services_pppoe.php b/src/usr/local/www/services_pppoe.php
index a0cf2f4..ecf807a 100644
--- a/src/usr/local/www/services_pppoe.php
+++ b/src/usr/local/www/services_pppoe.php
@@ -122,7 +122,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('vpnpppoe')) {
- print_info_box_np(gettext('The PPPoE entry list has been changed') . '.<br />' . gettext('You must apply the changes in order for them to take effect.'));
+ print_apply_box(gettext('The PPPoE entry list has been changed') . '.<br />' . gettext('You must apply the changes in order for them to take effect.'));
}
?>
diff --git a/src/usr/local/www/services_unbound.php b/src/usr/local/www/services_unbound.php
index 92b0c2f..2b26a4d 100644
--- a/src/usr/local/www/services_unbound.php
+++ b/src/usr/local/www/services_unbound.php
@@ -262,7 +262,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('unbound')) {
- print_info_box_np(gettext("The configuration of the DNS Resolver has been changed. You must apply changes for them to take effect."));
+ print_apply_box(gettext("The configuration of the DNS Resolver has been changed. You must apply changes for them to take effect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/services_unbound_acls.php b/src/usr/local/www/services_unbound_acls.php
index 7f2dc63..cd52d31 100644
--- a/src/usr/local/www/services_unbound_acls.php
+++ b/src/usr/local/www/services_unbound_acls.php
@@ -219,7 +219,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('unbound')) {
- print_info_box_np(gettext("The configuration of the DNS Resolver, has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The configuration of the DNS Resolver, has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/services_unbound_advanced.php b/src/usr/local/www/services_unbound_advanced.php
index c50248d..aca21cd 100644
--- a/src/usr/local/www/services_unbound_advanced.php
+++ b/src/usr/local/www/services_unbound_advanced.php
@@ -227,11 +227,11 @@ if ($input_errors) {
}
if ($savemsg) {
- print_info_box($savemsg, 'success');
+ print_info_box($savemsg, 'success');
}
if (is_subsystem_dirty('unbound')) {
- print_info_box_np(gettext("The configuration of the DNS Resolver has been changed. You must apply changes for them to take effect."));
+ print_apply_box(gettext("The configuration of the DNS Resolver has been changed. You must apply changes for them to take effect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/status_lb_pool.php b/src/usr/local/www/status_lb_pool.php
index f647c90..0b93843 100644
--- a/src/usr/local/www/status_lb_pool.php
+++ b/src/usr/local/www/status_lb_pool.php
@@ -145,7 +145,7 @@ if ($_POST) {
}
if (is_subsystem_dirty('loadbalancer')) {
- print_info_box_np(gettext('The load balancer configuration has been changed You must apply the changes in order for them to take effect.'));
+ print_apply_box(gettext('The load balancer configuration has been changed. You must apply the changes in order for them to take effect.'));
}
/* active tabs */
diff --git a/src/usr/local/www/status_queues.php b/src/usr/local/www/status_queues.php
index bc27f26..34f3ba3 100644
--- a/src/usr/local/www/status_queues.php
+++ b/src/usr/local/www/status_queues.php
@@ -214,7 +214,7 @@ else: ?>
<br />
<div class="infoblock blockopen">
<?php
- print_info_box(gettext("Queue graphs take 5 seconds to sample data"), 'info');
+ print_info_box(gettext("Queue graphs take 5 seconds to sample data"), 'info', false);
?>
</div>
</div>
diff --git a/src/usr/local/www/system_advanced_sysctl.php b/src/usr/local/www/system_advanced_sysctl.php
index bc49a63..28b7fc1 100644
--- a/src/usr/local/www/system_advanced_sysctl.php
+++ b/src/usr/local/www/system_advanced_sysctl.php
@@ -175,7 +175,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('sysctl') && ($act != "edit" )) {
- print_info_box_np(gettext("The firewall tunables have changed. You must apply the configuration for them to take affect."));
+ print_apply_box(gettext("The firewall tunables have changed. You must apply the configuration for them to take affect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/system_gateway_groups.php b/src/usr/local/www/system_gateway_groups.php
index 950020c..b1b82a2 100644
--- a/src/usr/local/www/system_gateway_groups.php
+++ b/src/usr/local/www/system_gateway_groups.php
@@ -131,7 +131,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('staticroutes')) {
- print_info_box_np(sprintf(gettext("The gateway configuration has been changed.%sYou must apply the changes in order for them to take effect."), "<br />"));
+ print_apply_box(sprintf(gettext("The gateway configuration has been changed.%sYou must apply the changes in order for them to take effect."), "<br />"));
}
$tab_array = array();
diff --git a/src/usr/local/www/system_gateways.php b/src/usr/local/www/system_gateways.php
index bb4c3d6..f94081b 100644
--- a/src/usr/local/www/system_gateways.php
+++ b/src/usr/local/www/system_gateways.php
@@ -254,7 +254,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('staticroutes')) {
- print_info_box_np(gettext("The gateway configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The gateway configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/system_groupmanager_addprivs.php b/src/usr/local/www/system_groupmanager_addprivs.php
index c705a93..6819e39 100644
--- a/src/usr/local/www/system_groupmanager_addprivs.php
+++ b/src/usr/local/www/system_groupmanager_addprivs.php
@@ -150,7 +150,7 @@ if ($_POST) {
/* if ajax is calling, give them an update message */
if (isAjax()) {
- print_info_box_np($savemsg, '', '', false, 'success');
+ print_info_box($savemsg, 'success');
}
function build_priv_list() {
diff --git a/src/usr/local/www/system_routes.php b/src/usr/local/www/system_routes.php
index 0babde8..a09a3c8 100644
--- a/src/usr/local/www/system_routes.php
+++ b/src/usr/local/www/system_routes.php
@@ -254,7 +254,7 @@ if ($savemsg) {
print_info_box($savemsg, 'success');
}
if (is_subsystem_dirty('staticroutes')) {
- print_info_box_np(gettext("The static route configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The static route configuration has been changed.") . "<br />" . gettext("You must apply the changes in order for them to take effect."));
}
$tab_array = array();
diff --git a/src/usr/local/www/system_usermanager_addprivs.php b/src/usr/local/www/system_usermanager_addprivs.php
index d683da6..69860ba 100644
--- a/src/usr/local/www/system_usermanager_addprivs.php
+++ b/src/usr/local/www/system_usermanager_addprivs.php
@@ -154,7 +154,7 @@ function build_priv_list() {
/* if ajax is calling, give them an update message */
if (isAjax()) {
- print_info_box_np($savemsg, '', '', false, 'success');
+ print_info_box($savemsg, 'success');
}
include("head.inc");
diff --git a/src/usr/local/www/vpn_ipsec.php b/src/usr/local/www/vpn_ipsec.php
index 56f2cf6..489f1b1 100644
--- a/src/usr/local/www/vpn_ipsec.php
+++ b/src/usr/local/www/vpn_ipsec.php
@@ -269,7 +269,7 @@ display_top_tabs($tab_array);
}
if (is_subsystem_dirty('ipsec')) {
- print_info_box_np(gettext("The IPsec tunnel configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The IPsec tunnel configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
}
?>
diff --git a/src/usr/local/www/vpn_ipsec_keys.php b/src/usr/local/www/vpn_ipsec_keys.php
index 053b408..004f274 100644
--- a/src/usr/local/www/vpn_ipsec_keys.php
+++ b/src/usr/local/www/vpn_ipsec_keys.php
@@ -115,7 +115,7 @@ if ($savemsg) {
}
if (is_subsystem_dirty('ipsec')) {
- print_info_box_np(gettext("The IPsec tunnel configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The IPsec tunnel configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
}
?>
diff --git a/src/usr/local/www/vpn_ipsec_mobile.php b/src/usr/local/www/vpn_ipsec_mobile.php
index 55692c3..bb3af4b 100644
--- a/src/usr/local/www/vpn_ipsec_mobile.php
+++ b/src/usr/local/www/vpn_ipsec_mobile.php
@@ -437,7 +437,7 @@ if ($savemsg) {
print_info_box($savemsg, 'success');
}
if (is_subsystem_dirty('ipsec')) {
- print_info_box_np(gettext("The IPsec tunnel configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
+ print_apply_box(gettext("The IPsec tunnel configuration has been changed") . ".<br />" . gettext("You must apply the changes in order for them to take effect."));
}
foreach ($a_phase1 as $ph1ent) {
if (isset($ph1ent['mobile'])) {
diff --git a/src/usr/local/www/vpn_l2tp.php b/src/usr/local/www/vpn_l2tp.php
index 12102ef..5d27c45 100644
--- a/src/usr/local/www/vpn_l2tp.php
+++ b/src/usr/local/www/vpn_l2tp.php
@@ -211,7 +211,7 @@ if ($_POST) {
/* if ajax is calling, give them an update message */
if (isAjax()) {
- print_info_box_np($savemsg, '', '', false, 'success');
+ print_info_box($savemsg, 'success');
}
}
}
diff --git a/src/usr/local/www/vpn_l2tp_users.php b/src/usr/local/www/vpn_l2tp_users.php
index cb9cc7d..5191e16 100644
--- a/src/usr/local/www/vpn_l2tp_users.php
+++ b/src/usr/local/www/vpn_l2tp_users.php
@@ -110,7 +110,7 @@ if (isset($config['l2tp']['radius']['enable'])) {
}
if (is_subsystem_dirty('l2tpusers')) {
- print_info_box_np(gettext("The l2tp user list has been modified") . ".<br />" . gettext("You must apply the changes in order for them to take effect") . ".<br /><b>" . gettext("Warning: this will terminate all current l2tp sessions!") . "</b>");
+ print_apply_box(gettext("The l2tp user list has been modified") . ".<br />" . gettext("You must apply the changes in order for them to take effect") . ".<br /><b>" . gettext("Warning: this will terminate all current l2tp sessions!") . "</b>");
}
diff --git a/src/usr/local/www/wizard.php b/src/usr/local/www/wizard.php
index 54a82e6..cfe95f9 100644
--- a/src/usr/local/www/wizard.php
+++ b/src/usr/local/www/wizard.php
@@ -89,25 +89,25 @@ if ($_POST['xml']) {
if (empty($xml)) {
$xml = "not_defined";
- print_info_box_np(sprintf(gettext("ERROR: Could not open %s."), $xml));
+ print_info_box(sprintf(gettext("ERROR: Could not open %s."), $xml));
die;
} else {
$wizard_xml_prefix = "{$g['www_path']}/wizards";
$wizard_full_path = "{$wizard_xml_prefix}/{$xml}";
if (substr_compare(realpath($wizard_full_path), $wizard_xml_prefix, 0, strlen($wizard_xml_prefix))) {
- print_info_box_np(gettext("ERROR: Invalid path specified."));
+ print_info_box(gettext("ERROR: Invalid path specified."));
die;
}
if (file_exists($wizard_full_path)) {
$pkg = parse_xml_config_pkg($wizard_full_path, "pfsensewizard");
} else {
- print_info_box_np(sprintf(gettext("ERROR: Could not open %s."), $xml));
+ print_info_box(sprintf(gettext("ERROR: Could not open %s."), $xml));
die;
}
}
if (!is_array($pkg)) {
- print_info_box_np(sprintf(gettext("ERROR: Could not parse %s/wizards/%s file."), $g['www_path'], $xml));
+ print_info_box(sprintf(gettext("ERROR: Could not parse %s/wizards/%s file."), $g['www_path'], $xml));
die;
}
diff --git a/src/usr/local/www/wizards/setup_wizard.xml b/src/usr/local/www/wizards/setup_wizard.xml
index 20281f7..4914c89 100644
--- a/src/usr/local/www/wizards/setup_wizard.xml
+++ b/src/usr/local/www/wizards/setup_wizard.xml
@@ -621,7 +621,7 @@
<stepsubmitphpaction>
<![CDATA[
if(empty($_POST['lanipaddress']) || !is_ipaddr($_POST['lanipaddress'])) {
- print_info_box_np("Invalid LAN IP Address. Please press back in your browser window and correct.");
+ print_info_box("Invalid LAN IP Address. Please press back in your browser window and correct.");
die;
}
@@ -709,7 +709,7 @@
local_user_set($admin_user);
write_config();
} else {
- print_info_box_np("Passwords do not match! Please press back in your browser window and correct.");
+ print_info_box("Passwords do not match! Please press back in your browser window and correct.");
die;
}
}
OpenPOWER on IntegriCloud