diff options
author | NOYB <Al_Stu@Frontier.com> | 2016-02-17 16:43:33 -0800 |
---|---|---|
committer | NOYB <Al_Stu@Frontier.com> | 2016-02-17 16:43:33 -0800 |
commit | 37f73a7ca703830cc5b407696e158cc8870f5457 (patch) | |
tree | 5962f2db71f10af79185e8ffd31317f7c4972363 /src/usr/local/www | |
parent | c6c187f3d8f0ac83d230e58c3c3863b2be567d1a (diff) | |
download | pfsense-37f73a7ca703830cc5b407696e158cc8870f5457.zip pfsense-37f73a7ca703830cc5b407696e158cc8870f5457.tar.gz |
Diagnostics / Tables - Large Tables Perf Band-Aid
Here's my band-aid proposal for large tables performance issue.
I would prefer for large tables be un-formated and usable than formated and unusable.
Diffstat (limited to 'src/usr/local/www')
-rw-r--r-- | src/usr/local/www/diag_tables.php | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/src/usr/local/www/diag_tables.php b/src/usr/local/www/diag_tables.php index 567cb80..1dffab3 100644 --- a/src/usr/local/www/diag_tables.php +++ b/src/usr/local/www/diag_tables.php @@ -226,6 +226,17 @@ if (empty($entries)) { </thead> <tbody> <?php + // This is a band-aid for a yet to be root caused performance issue with large tables. Suspected is css and/or sorting. + if (count($entries) > 3000) { + print "<tr><td colspan='2'><pre>"; + foreach ($entries as $entry) { + $entry = trim($entry); + print $entry . "\n"; + } + print "</pre></td></tr>"; + } else { +?> +<?php foreach ($entries as $entry): $entry = trim($entry); ?> @@ -240,6 +251,7 @@ if (empty($entries)) { </td> </tr> <?php endforeach ?> +<?php } ?> </tbody> </table> </div> |