diff options
| author | Phil Davis <phil.davis@inf.org> | 2015-12-17 12:23:24 +0545 |
|---|---|---|
| committer | Phil Davis <phil.davis@inf.org> | 2015-12-17 12:23:24 +0545 |
| commit | f402c3bcaffe67a9d73aa7cda741c2daca01685f (patch) | |
| tree | f273729850a82ff9f4501d36b640e4a60e420b58 /src/usr/local/www/widgets | |
| parent | 0cf1b4f4f29f2ad63691d598e83a9327ae9867ff (diff) | |
| download | pfsense-f402c3bcaffe67a9d73aa7cda741c2daca01685f.zip pfsense-f402c3bcaffe67a9d73aa7cda741c2daca01685f.tar.gz | |
dyn_dns_status widget avoid var naming issue
This use of var $i was conflicting and interfering with a use of it in
index.php
Use a much more unique name for now to avoid future risk.
Maybe a proper final solution for var naming across dashboard and widget
is needed - but that is a design issue to be discussed.
Diffstat (limited to 'src/usr/local/www/widgets')
| -rw-r--r-- | src/usr/local/www/widgets/widgets/dyn_dns_status.widget.php | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/usr/local/www/widgets/widgets/dyn_dns_status.widget.php b/src/usr/local/www/widgets/widgets/dyn_dns_status.widget.php index b450915..2eb1c84 100644 --- a/src/usr/local/www/widgets/widgets/dyn_dns_status.widget.php +++ b/src/usr/local/www/widgets/widgets/dyn_dns_status.widget.php @@ -105,8 +105,8 @@ if ($_REQUEST['getdyndnsstatus']) { <td width="20%" class="listhdrr"><?=gettext("Hostname");?></td> <td width="20%" class="listhdrr"><?=gettext("Cached IP");?></td> </tr> - <?php $i = 0; foreach ($a_dyndns as $dyndns): ?> - <tr ondblclick="document.location='services_dyndns_edit.php?id=<?=$i;?>'"> + <?php $dyndnsid = 0; foreach ($a_dyndns as $dyndns): ?> + <tr ondblclick="document.location='services_dyndns_edit.php?id=<?=$dyndnsid;?>'"> <td class="listlr"> <?php $iflist = get_configured_interface_with_descr(); foreach ($iflist as $if => $ifdesc) { @@ -158,10 +158,10 @@ if ($_REQUEST['getdyndnsstatus']) { ?> </td> <td class="listr"> - <div id='dyndnsstatus<?= $i;?>'><?= gettext("Checking ...");?></div> + <div id='dyndnsstatus<?= $dyndnsid;?>'><?= gettext("Checking ...");?></div> </td> </tr> - <?php $i++; endforeach;?> + <?php $dyndnsid++; endforeach;?> </table> </div> <script type="text/javascript"> |
