summaryrefslogtreecommitdiffstats
path: root/src/usr/local/www/system.php
diff options
context:
space:
mode:
authorNewEraCracker <neweracracker@gmail.com>2016-02-22 16:53:28 +0000
committerNewEraCracker <neweracracker@gmail.com>2016-02-22 16:53:28 +0000
commit58b07c57bf91e5f32d17d239d4250639ecc21e7c (patch)
tree9b33d92355de63d78ba99941d1690743e8982b94 /src/usr/local/www/system.php
parenta936104b3721ef60dd79b09ede67cea3d12d8093 (diff)
downloadpfsense-58b07c57bf91e5f32d17d239d4250639ecc21e7c.zip
pfsense-58b07c57bf91e5f32d17d239d4250639ecc21e7c.tar.gz
Initialize variables correctly
1) gmirror.inc: there are two calls to exec(), those calls expect the 2nd parameter to be an array, this commit initializes the variables correctly. 2) system.php: variable dnslist is used as an array without prior type initialization. This is one of the causes for apparent PR #2680 problems (which led to its reversal). Note: After this commit is merged PR #2680 may be safely reapplied for more tough code.
Diffstat (limited to 'src/usr/local/www/system.php')
-rw-r--r--src/usr/local/www/system.php2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/usr/local/www/system.php b/src/usr/local/www/system.php
index 3663e21..884ab4c 100644
--- a/src/usr/local/www/system.php
+++ b/src/usr/local/www/system.php
@@ -175,7 +175,7 @@ if ($_POST) {
$input_errors[] = gettext("The domain may only contain the characters a-z, 0-9, '-' and '.'.");
}
- $ignore_posted_dnsgw = array();
+ $dnslist = $ignore_posted_dnsgw = array();
for ($dnscounter=1; $dnscounter<5; $dnscounter++) {
$dnsname="dns{$dnscounter}";
OpenPOWER on IntegriCloud