diff options
author | Phil Davis <phil.davis@inf.org> | 2015-12-23 09:49:48 +0545 |
---|---|---|
committer | Phil Davis <phil.davis@inf.org> | 2015-12-23 09:49:48 +0545 |
commit | c46008ae1838acb21dda155173c19aaf49b90775 (patch) | |
tree | 77513e429faf35d4a07f5aea6b6fb8ada7940aaa /src/usr/local/www/interfaces_lagg_edit.php | |
parent | 5a2512b3cdb249e3eeda8e480dfbac80deb37e7d (diff) | |
download | pfsense-c46008ae1838acb21dda155173c19aaf49b90775.zip pfsense-c46008ae1838acb21dda155173c19aaf49b90775.tar.gz |
LAGG edit fixes
1) $_POST['members'] is an array, but $pconfig['members'] should be a comma-separated list. So the general copy "$pconfig = $_POST;" needs to be followed by setting up 'members' in particular.
2) $members_array is never used - so throw it away.
3) Add code so that input errors are actually displayed to the user.
Forum thread: https://forum.pfsense.org/index.php?topic=104352.0
Diffstat (limited to 'src/usr/local/www/interfaces_lagg_edit.php')
-rw-r--r-- | src/usr/local/www/interfaces_lagg_edit.php | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/usr/local/www/interfaces_lagg_edit.php b/src/usr/local/www/interfaces_lagg_edit.php index effd171..ea26d3c 100644 --- a/src/usr/local/www/interfaces_lagg_edit.php +++ b/src/usr/local/www/interfaces_lagg_edit.php @@ -163,6 +163,7 @@ if (isset($id) && $a_laggs[$id]) { if ($_POST) { unset($input_errors); $pconfig = $_POST; + $pconfig['members'] = implode(',', $_POST['members']); /* input validation */ $reqdfields = explode(" ", "members proto"); @@ -223,7 +224,6 @@ function build_member_list() { $memberlist = array('list' => array(), 'selected' => array()); - $members_array = explode(',', $pconfig['members']); foreach ($portlist as $ifn => $ifinfo) { if (array_key_exists($ifn, $realifchecklist)) { continue; @@ -242,6 +242,11 @@ function build_member_list() { $pgtitle = array(gettext("Interfaces"), gettext("LAGG"), gettext("Edit")); $shortcut_section = "interfaces"; include("head.inc"); + +if ($input_errors) { + print_input_errors($input_errors); +} + $form = new Form(); $section = new Form_Section('LAGG Configuration'); |