summaryrefslogtreecommitdiffstats
path: root/src/usr/local/www/firewall_shaper.php
diff options
context:
space:
mode:
authorColin Fleming <cj_fleming@sky.com>2015-12-04 13:12:37 +0000
committerColin Fleming <cj_fleming@sky.com>2015-12-04 13:12:37 +0000
commit7841a35cc63db59d44e228b47452283e4d0d5420 (patch)
treef37f954a9144224ab08c6b12afbc80110725a473 /src/usr/local/www/firewall_shaper.php
parentbc03c2e06dd8a7cbadb05566c7cea03495fc3bbb (diff)
downloadpfsense-7841a35cc63db59d44e228b47452283e4d0d5420.zip
pfsense-7841a35cc63db59d44e228b47452283e4d0d5420.tar.gz
Tidy up "firewall_shaper*.php"
Tidy up coding style Add PROPERTY statement to LINK tag Remove self closing statement from ANCHOR tag
Diffstat (limited to 'src/usr/local/www/firewall_shaper.php')
-rw-r--r--src/usr/local/www/firewall_shaper.php42
1 files changed, 24 insertions, 18 deletions
diff --git a/src/usr/local/www/firewall_shaper.php b/src/usr/local/www/firewall_shaper.php
index 971718b..e439aed 100644
--- a/src/usr/local/www/firewall_shaper.php
+++ b/src/usr/local/www/firewall_shaper.php
@@ -217,19 +217,19 @@ if ($_GET) {
case "show":
if ($queue) {
$sform = $queue->build_form();
- }
- else
+ } else {
$input_errors[] = gettext("Queue not found!");
+ }
break;
case "enable":
if ($queue) {
- $queue->SetEnabled("on");
- $sform = $queue->build_form();
- if (write_config()) {
- mark_subsystem_dirty('shaper');
- }
+ $queue->SetEnabled("on");
+ $sform = $queue->build_form();
+ if (write_config()) {
+ mark_subsystem_dirty('shaper');
+ }
} else {
- $input_errors[] = gettext("Queue not found!");
+ $input_errors[] = gettext("Queue not found!");
}
break;
case "disable":
@@ -240,7 +240,7 @@ if ($_GET) {
mark_subsystem_dirty('shaper');
}
} else {
- $input_errors[] = gettext("Queue not found!");
+ $input_errors[] = gettext("Queue not found!");
}
break;
default:
@@ -411,19 +411,23 @@ if (is_array($altq_list_queues)) {
$tree .= "</ul>";
-if ($queue)
+if ($queue) {
print($queue->build_javascript());
+}
print($newjavascript);
-if ($input_errors)
+if ($input_errors) {
print_input_errors($input_errors);
+}
-if ($savemsg)
+if ($savemsg) {
print_info_box($savemsg, 'success');
+}
-if (is_subsystem_dirty('shaper'))
+if (is_subsystem_dirty('shaper')) {
print_info_box_np(gettext("The traffic shaper configuration has been changed. You must apply the changes in order for them to take effect."));
+}
$tab_array = array();
$tab_array[] = array(gettext("By Interface"), true, "firewall_shaper.php");
@@ -433,7 +437,7 @@ $tab_array[] = array(gettext("Wizards"), false, "firewall_shaper_wizards.php");
display_top_tabs($tab_array);
?>
-<link rel="stylesheet" type="text/css" media="all" href="./tree/tree.css" />
+<link rel="stylesheet" type="text/css" media="all" href="./tree/tree.css" property="stylesheet" />
<script type="text/javascript" src="./tree/tree.js"></script>
<div class="table-responsive">
@@ -461,10 +465,11 @@ if (!$dfltmsg) {
// Add global buttons
if (!$dontshow || $newqueue) {
if ($can_add || $addnewaltq) {
- if ($queue)
+ if ($queue) {
$url = 'firewall_shaper.php?interface='. $interface . '&queue=' . $queue->GetQname() . '&action=add';
- else
+ } else {
$url = 'firewall_shaper.php?interface='. $interface . '&action=add';
+ }
$sform->addGlobal(new Form_Button(
'add',
@@ -474,10 +479,11 @@ if (!$dfltmsg) {
}
- if ($queue)
+ if ($queue) {
$url = 'firewall_shaper.php?interface='. $interface . '&queue=' . $queue->GetQname() . '&action=delete';
- else
+ } else {
$url = 'firewall_shaper.php?interface='. $interface . '&action=delete';
+ }
$sform->addGlobal(new Form_Button(
'delete',
OpenPOWER on IntegriCloud