diff options
| author | Phil Davis <phil.davis@inf.org> | 2017-01-01 11:01:38 +0545 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-01-01 11:01:38 +0545 |
| commit | cffe1271c962ac9159c43fd214c735ceb4b5e1b8 (patch) | |
| tree | 3256c797d78dec1e80aa9d25d9e797eccee725fc /src/usr/local/www/firewall_rules_edit.php | |
| parent | 56110c7249b5dbd9ea4e0b4c4009794c69a58143 (diff) | |
| download | pfsense-cffe1271c962ac9159c43fd214c735ceb4b5e1b8.zip pfsense-cffe1271c962ac9159c43fd214c735ceb4b5e1b8.tar.gz | |
Remove redundant gettext() in firewall_rules_edit
The 'helpmsg' here is already translated with gettext() when the 'helpmsg' array entries are set up, so IMHO there is no need to attempt translation again.
Diffstat (limited to 'src/usr/local/www/firewall_rules_edit.php')
| -rw-r--r-- | src/usr/local/www/firewall_rules_edit.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/usr/local/www/firewall_rules_edit.php b/src/usr/local/www/firewall_rules_edit.php index 6cea900..798f053 100644 --- a/src/usr/local/www/firewall_rules_edit.php +++ b/src/usr/local/www/firewall_rules_edit.php @@ -1288,7 +1288,7 @@ $group->add(new Form_Select( ((isset($pconfig['icmptype']) && strlen($pconfig['icmptype']) > 0) ? explode(',', $pconfig['icmptype']) : 'any'), isset($icmplookup[$pconfig['ipprotocol']]) ? $icmplookup[$pconfig['ipprotocol']]['icmptypes'] : array('any' => gettext('any')), true -))->setHelp('<div id="icmptype_help">' . (isset($icmplookup[$pconfig['ipprotocol']]) ? gettext($icmplookup[$pconfig['ipprotocol']]['helpmsg']) : '') . '</div>'); +))->setHelp('<div id="icmptype_help">' . (isset($icmplookup[$pconfig['ipprotocol']]) ? $icmplookup[$pconfig['ipprotocol']]['helpmsg'] : '') . '</div>'); $group->addClass('icmptype_section'); $section->add($group); @@ -1963,7 +1963,7 @@ events.push(function() { $a[] = sprintf("'%s':'%s'", $icmp_k, $icmp_v); } $out1 .= "icmptypes['{$k}'] = {\n\t" . implode(",\n\t", $a) . "\n};\n"; - $out2 .= "icmphelp['{$k}'] = '" . str_replace("'", ''', gettext($v['helpmsg'])) . "';\n"; + $out2 .= "icmphelp['{$k}'] = '" . str_replace("'", ''', $v['helpmsg']) . "';\n"; } echo $out1; echo $out2; |
