summaryrefslogtreecommitdiffstats
path: root/src/usr/local/www/firewall_rules_edit.php
diff options
context:
space:
mode:
authorstilez <stilez@users.noreply.github.com>2016-12-29 08:22:06 +0000
committerRenato Botelho <renato@netgate.com>2016-12-30 10:06:57 -0200
commit059571c6e0b7dd93f876ae2b7823547ef1cb6dae (patch)
treea2940329cf9d431d7052d06cc1057713e1e80963 /src/usr/local/www/firewall_rules_edit.php
parentee781eaaccd9f6ac54e11c531f3321bd0ec5b738 (diff)
downloadpfsense-059571c6e0b7dd93f876ae2b7823547ef1cb6dae.zip
pfsense-059571c6e0b7dd93f876ae2b7823547ef1cb6dae.tar.gz
"Any" moved to top of list in new blank rules
@jim-p wanted this split out from PR 3159 as it wasn't related to that PR. Puts "any" at the logical place people look for it (top of list not 2/3 down it at random) while ensuring that for new rules default is tcp and extra ports etc fields are visible. (cherry picked from commit e9b3d2c3bfc3e91ac59901ca28d0620f7bb7b50f)
Diffstat (limited to 'src/usr/local/www/firewall_rules_edit.php')
-rw-r--r--src/usr/local/www/firewall_rules_edit.php3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/usr/local/www/firewall_rules_edit.php b/src/usr/local/www/firewall_rules_edit.php
index 010e533..a756960 100644
--- a/src/usr/local/www/firewall_rules_edit.php
+++ b/src/usr/local/www/firewall_rules_edit.php
@@ -328,6 +328,7 @@ if (isset($id) && $a_filter[$id]) {
$pconfig['interface'] = $_GET['if'];
}
$pconfig['type'] = "pass";
+ $pconfig['proto'] = "tcp"; // for new blank rules, default=tcp, also ensures ports fields are visible
$pconfig['src'] = "any";
$pconfig['dst'] = "any";
}
@@ -1299,6 +1300,7 @@ $section->addInput(new Form_Select(
'Protocol',
$pconfig['proto'],
array(
+ 'any' => gettext('any'),
'tcp' => 'TCP',
'udp' => 'UDP',
'tcp/udp' => 'TCP/UDP',
@@ -1311,7 +1313,6 @@ $section->addInput(new Form_Select(
'pim' => 'PIM',
'ospf' => 'OSPF',
'sctp' => 'SCTP',
- 'any' => gettext('any'),
'carp' => 'CARP',
'pfsync' => 'PFSYNC',
)
OpenPOWER on IntegriCloud