Retire PPTP server, fixes #4226:

- Remove PPTP server and all related code
- Bump config version 12.2
- Write upgrade config code to remove pptpd section and also cleanup
  firewall and NAT rules using PPTP interface or src/des

1 files changed, 0 insertions, 5 deletions

diff --git a/src/usr/local/www/firewall_rules_edit.php b/src/usr/local/www/firewall_rules_edit.php
index 1630395..c32a226 100644
--- a/src/usr/local/www/firewall_rules_edit.php
+++ b/src/usr/local/www/firewall_rules_edit.php
@@ -1132,9 +1132,6 @@ foreach (get_configured_interface_with_descr() as $ifent => $ifdesc)
 if ($config['l2tp']['mode'] == "server" && have_ruleint_access("l2tp"))
 	$interfaces['l2tp'] = 'L2TP VPN';
 
-if ($config['pptpd']['mode'] == "server" && have_ruleint_access("pptp"))
-	$interfaces['pptp'] = 'PPTP VPN';
-
 if (is_pppoe_server_enabled() && have_ruleint_access("pppoe"))
 	$interfaces['pppoe'] = "PPPoE Server";
 
@@ -1256,8 +1253,6 @@ foreach (['src' => 'Source', 'dst' => 'Destination'] as $type => $name) {
 	);
 	if (isset($a_filter[$id]['floating']) || $if == "FloatingRules")
 		$ruleValues['(self)'] = 'This Firewall (self)';
-	if (have_ruleint_access("pptp"))
-		$ruleValues['pptp'] = 'PPTP clients';
 	if (have_ruleint_access("pppoe"))
 		$ruleValues['pppoe'] = 'PPPoE clients';
 	if (have_ruleint_access("l2tp"))