diff options
| author | stilez <stilez@users.noreply.github.com> | 2016-12-27 01:15:14 +0000 |
|---|---|---|
| committer | Renato Botelho <renato@netgate.com> | 2016-12-30 09:54:03 -0200 |
| commit | ab2822c82cd5741e8f352f7812fe90e477c14fa5 (patch) | |
| tree | 18b11e23721cc9fdb96323c2d6fcd968a1d42b52 /src/usr/local/www/firewall_rules.php | |
| parent | 744c5ffc5c7fb2eae3ccfcf0f886a92842ec0ae6 (diff) | |
| download | pfsense-ab2822c82cd5741e8f352f7812fe90e477c14fa5.zip pfsense-ab2822c82cd5741e8f352f7812fe90e477c14fa5.tar.gz | |
improve CSS handling for icmp types (overflow/table)
Minor CSS and formatting improvement to layout for icmp types in rules table. With this change, if several icmp types are specified in the rule, if they won't fit into 2 lines the GUI automatically switches to a scrollable overflow instead, to preserve the table layout. Also underlining is per icmptype so commas etc aren't underlined which is much easier to read
(cherry picked from commit 675c9e59db5e41bc6cf922a07fa262bfc5656f1c)
Diffstat (limited to 'src/usr/local/www/firewall_rules.php')
| -rw-r--r-- | src/usr/local/www/firewall_rules.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/usr/local/www/firewall_rules.php b/src/usr/local/www/firewall_rules.php index d833f55..9ad2329 100644 --- a/src/usr/local/www/firewall_rules.php +++ b/src/usr/local/www/firewall_rules.php @@ -730,7 +730,7 @@ foreach ($a_filter as $filteri => $filterent): explode(',', $filterent['icmptype']) ) ); - echo sprintf(' <span style="cursor: help;" title="%s:%s%s"><u>%s</u></span>', gettext('ICMP subtypes'), chr(13), $t, $filterent['icmptype']); + echo sprintf('<br /><div style="cursor:help;padding:1px;line-height:1.1em;max-height:2.5em;max-width:180px;overflow-y:auto;overflow-x:hidden" title="%s:%s%s"><small><u>%s</u></small></div>', gettext('ICMP subtypes'), chr(13), $t, str_replace(',', '</u>, <u>',$filterent['icmptype'])); } } else { echo " *"; |
