diff options
| author | Renato Botelho <renato@netgate.com> | 2016-12-09 18:21:44 -0200 |
|---|---|---|
| committer | Renato Botelho <renato@netgate.com> | 2016-12-09 18:25:32 -0200 |
| commit | 3335fee96e09541226a1d5e156911860090ef701 (patch) | |
| tree | 903b65a24bccbdf4ec67f68a8b4476e8459ce3ef /src/usr/local/www/firewall_nat_edit.php | |
| parent | 6d52d0bfe1b67d037f9d7d1d77120b6c3fa863c0 (diff) | |
| download | pfsense-3335fee96e09541226a1d5e156911860090ef701.zip pfsense-3335fee96e09541226a1d5e156911860090ef701.tar.gz | |
Do not set disabled or nordr fields when they are not selected. Checks are using isset() and not its boolean value
Diffstat (limited to 'src/usr/local/www/firewall_nat_edit.php')
| -rw-r--r-- | src/usr/local/www/firewall_nat_edit.php | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/usr/local/www/firewall_nat_edit.php b/src/usr/local/www/firewall_nat_edit.php index fe5b614..7ed4945 100644 --- a/src/usr/local/www/firewall_nat_edit.php +++ b/src/usr/local/www/firewall_nat_edit.php @@ -390,8 +390,13 @@ if ($_POST) { $natent = array(); - $natent['disabled'] = isset($_POST['disabled']) ? true:false; - $natent['nordr'] = isset($_POST['nordr']) ? true:false; + if (isset($_POST['disabled'])) { + $natent['disabled'] = true; + } + + if (isset($_POST['nordr'])) { + $natent['nordr'] = true; + } if ($natent['nordr']) { $_POST['associated-rule-id'] = ''; @@ -408,7 +413,7 @@ if ($_POST) { $natent['protocol'] = $_POST['proto']; - if (!$natent['nordr']) { + if (!isset($natent['nordr'])) { $natent['target'] = $_POST['localip']; $natent['local-port'] = $_POST['localbeginport']; } |
