summaryrefslogtreecommitdiffstats
path: root/src/usr/local/www/diag_smart.php
diff options
context:
space:
mode:
authorjim-p <jimp@pfsense.org>2016-05-20 11:33:48 -0400
committerjim-p <jimp@pfsense.org>2016-05-20 11:34:35 -0400
commit0e4e4251ebf09937e7069a94f5faef51bbe15fac (patch)
tree6038dcca56498127ef2259ffca90452e6e72bf3d /src/usr/local/www/diag_smart.php
parentc805b6e413dc0ecfb4313198e0d0be6c7e08675b (diff)
downloadpfsense-0e4e4251ebf09937e7069a94f5faef51bbe15fac.zip
pfsense-0e4e4251ebf09937e7069a94f5faef51bbe15fac.tar.gz
Better fix for escaping in ticket #6371
Diffstat (limited to 'src/usr/local/www/diag_smart.php')
-rw-r--r--src/usr/local/www/diag_smart.php2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/usr/local/www/diag_smart.php b/src/usr/local/www/diag_smart.php
index 9b6bfd4..e7be8de 100644
--- a/src/usr/local/www/diag_smart.php
+++ b/src/usr/local/www/diag_smart.php
@@ -111,7 +111,7 @@ function update_email($email) {
// Did they pass an email?
if (!empty($email)) {
// Put it in the smartd.conf file
- shell_exec("/usr/bin/sed -i .old 's/^DEVICESCAN.*/DEVICESCAN -H -m " . escapeshellarg(str_replace('`', '', $email)) . "/' /usr/local/etc/smartd.conf");
+ shell_exec("/usr/bin/sed -i .old " . escapeshellarg("s/^DEVICESCAN.*/DEVICESCAN -H -m {$email}/") . " /usr/local/etc/smartd.conf");
} else {
// Remove email flags in smartd.conf
shell_exec("/usr/bin/sed -i .old 's/^DEVICESCAN.*/DEVICESCAN/' /usr/local/etc/smartd.conf");
OpenPOWER on IntegriCloud