diff options
| author | jim-p <jimp@pfsense.org> | 2011-05-25 12:29:09 -0400 |
|---|---|---|
| committer | jim-p <jimp@pfsense.org> | 2011-05-25 12:29:31 -0400 |
| commit | 7788c76a4e9e04b356f40f2129ff5309617dad99 (patch) | |
| tree | 83cc5f3660246fbd1fac431594be8a90273dca01 /etc | |
| parent | c749ef62ec8ecb3d7f38f7de49e5029631614ef5 (diff) | |
| download | pfsense-7788c76a4e9e04b356f40f2129ff5309617dad99.zip pfsense-7788c76a4e9e04b356f40f2129ff5309617dad99.tar.gz | |
Don't overwrite the $target variable. Fixes #1415
Diffstat (limited to 'etc')
| -rw-r--r-- | etc/inc/filter.inc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/etc/inc/filter.inc b/etc/inc/filter.inc index 67bc1f3..3ce44a3 100644 --- a/etc/inc/filter.inc +++ b/etc/inc/filter.inc @@ -1039,7 +1039,6 @@ function filter_generate_reflection($rule, $nordr, $rdr_ifs, $srcaddr, $dstaddr_ $target = $FilterIflist[$rule['target']]['ip']; else return ""; - $starting_localhost_port_tmp = $starting_localhost_port; $toomanyports = false; /* only install reflection rules for < 19991 items */ @@ -1088,7 +1087,7 @@ function filter_generate_reflection($rule, $nordr, $rdr_ifs, $srcaddr, $dstaddr_ $toadd_array = array_merge($toadd_array, range($loc_pt[0], $loc_pt[0] + $delta)); if(!empty($toadd_array)) { - $target = explode(" ", trim($target)); + $rtarget = explode(" ", trim($target)); foreach($toadd_array as $tda) { if (empty($tda)) continue; @@ -1100,7 +1099,7 @@ function filter_generate_reflection($rule, $nordr, $rdr_ifs, $srcaddr, $dstaddr_ $socktype = "stream"; $dash_u = ""; } - foreach ($target as $targip) { + foreach ($rtarget as $targip) { if (empty($targip)) continue; $reflection_txt[] = "{$inetdport}\t{$socktype}\t{$reflect_proto}\tnowait/0\tnobody\t/usr/bin/nc\tnc {$dash_u}-w {$reflectiontimeout} {$targip} {$tda}\n"; |
