Fixes #684. Test file existence before trying to kill the process. Also correct interface name passed as parameter to interface_configure function, it should fix another ticket as a byproduct.

1 files changed, 5 insertions, 3 deletions

diff --git a/etc/inc/interfaces.inc b/etc/inc/interfaces.inc
index 5196205..d10f322 100644
--- a/etc/inc/interfaces.inc
+++ b/etc/inc/interfaces.inc
@@ -824,11 +824,13 @@ function interface_bring_down($interface = "wan", $destroy = false) {
 		if (is_array($config['ppps']['ppp']) && count($config['ppps']['ppp'])) {
 			foreach ($config['ppps']['ppp'] as $pppid => $ppp) {
 				if ($realif == $ppp['if']) {
-					killbypid("{$g['varrun_path']}/{$ifcfg['ipaddr']}_{$interface}.pid");
-					sleep(2);
+					if (file_exists("{$g['varrun_path']}/{$ifcfg['ipaddr']}_{$interface}.pid")) {
+						killbypid("{$g['varrun_path']}/{$ifcfg['ipaddr']}_{$interface}.pid");
+						sleep(2);
+					}
 					unlink_if_exists("{$g['varetc_path']}/mpd_{$interface}.conf");
 					if (isset($ppp['ondemand']) && !$destroy) {
-						interface_configure("wan");
+						interface_configure($interface);
 					}
 					break;
 				}