Make this more readble and also do not trigger an interface_bring_up on a down event.

1 files changed, 9 insertions, 5 deletions

diff --git a/etc/rc.linkup b/etc/rc.linkup
index 92db7f7..29d3c5c 100755
--- a/etc/rc.linkup
+++ b/etc/rc.linkup
@@ -65,11 +65,15 @@ function handle_argument_group($iface, $argument2) {
 		$friendly = convert_friendly_interface_to_friendly_descr($iface);
 		log_error("Hotplug event detected for {$friendly}({$iface}) but ignoring since interface is configured with static IP ({$ipaddr} {$ip6addr})");
 		interfaces_staticarp_configure($iface);
-		$iface = get_real_interface($iface);
-		interfaces_bring_up($iface);
-		/* NOTE: Do not generate event for OpenVPN since the daemon does that for us. */
-		if (($argument2 == "start" || $argument2 == "up") && substr($iface, 0, 4) != "ovpn")
-			send_event("interface newip {$iface}");
+		switch ($argument2) {
+		case 'start':
+		case 'up':
+			$iface = get_real_interface($iface);
+			/* NOTE: Do not generate event for OpenVPN since the daemon does that for us. */
+			if (substr($iface, 0, 4) != "ovpn")
+				send_event("interface newip {$iface}");
+			break;
+		}
 	} else {
 		switch ($argument2) {
 		case "stop":