Ticket #1006. Make sure to interpret the response as needed. First check if we got 0 and then check if we have a faultCode().

1 files changed, 2 insertions, 5 deletions

diff --git a/etc/rc.filter_synchronize b/etc/rc.filter_synchronize
index 3febef0..34198b4 100755
--- a/etc/rc.filter_synchronize
+++ b/etc/rc.filter_synchronize
@@ -185,19 +185,16 @@ function carp_sync_xml($url, $password, $sections, $port = 80, $method = 'pfsens
 			$cli->setDebug(1);
 		/* send our XMLRPC message and timeout after 240 seconds */
 		$resp = $cli->send($msg, "240");
-		if($resp->faultCode()) {
-			$error = "A communications error occurred while attempting communication with {$url}:{$port} (pfsense.exec_php).";
-			log_error($error);
-			return;	
-		}
 		if(!$resp) {
 			$error = "A communications error occured while attempting XMLRPC sync with username {$username} {$url}:{$port}.";
 			log_error($error);
 			file_notice("sync_settings", $error, "Settings Sync", "");
+			continue;
 		} elseif($resp->faultCode()) {
 			$error = "An error code was received while attempting XMLRPC sync with username {$username} {$url}:{$port} - Code " . $resp->faultCode() . ": " . $resp->faultString();
 			log_error($error);
 			file_notice("sync_settings", $error, "Settings Sync", "");
+			continue;
 		} else {
 			log_error("XMLRPC sync successfully completed with {$url}:{$port}.");
 			$numberofruns = 3;