diff options
author | Ermal <eri@pfsense.org> | 2010-09-08 16:56:52 +0000 |
---|---|---|
committer | Ermal <eri@pfsense.org> | 2010-09-08 16:56:52 +0000 |
commit | e5953c6811f3fce1fa6b9a6b24451d9cb47cdf57 (patch) | |
tree | 87ce96ae4ba276cda8d2ca1edffa96d14ffa2186 /etc/inc/pfsense-utils.inc | |
parent | e8d0903de4ed50fb630fc939ce0539efcea8ddd2 (diff) | |
download | pfsense-e5953c6811f3fce1fa6b9a6b24451d9cb47cdf57.zip pfsense-e5953c6811f3fce1fa6b9a6b24451d9cb47cdf57.tar.gz |
Use foreach and check for type to avoid errors.
Diffstat (limited to 'etc/inc/pfsense-utils.inc')
-rw-r--r-- | etc/inc/pfsense-utils.inc | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/etc/inc/pfsense-utils.inc b/etc/inc/pfsense-utils.inc index 0498b2e..9c50dd2 100644 --- a/etc/inc/pfsense-utils.inc +++ b/etc/inc/pfsense-utils.inc @@ -1593,10 +1593,14 @@ function update_alias_names_upon_change($section, $subsection, $fielda, $fieldb, function update_alias_url_data() { global $config, $g; + /* item is a url type */ $lockkey = lock('config'); - for($x=0; $x<count($config['aliases']['alias']); $x++) { - if($config['aliases']['alias'][$x]['aliasurl']) { + if (is_array($config['aliases']['alias'])) { + foreach ($config['aliases']['alias'] as $x => $alias) { + if (empty($alias['aliasurl'])) + continue; + /* fetch down and add in */ $isfirst = 0; $temp_filename = tempnam("{$g['tmp_path']}/", "alias_import"); @@ -1607,9 +1611,9 @@ function update_alias_url_data() { mwexec("/bin/mkdir -p {$temp_filename}"); mwexec("/usr/bin/fetch -q -o \"{$temp_filename}/aliases\" \"" . $config['aliases']['alias'][$x]['aliasurl'] . "\""); /* if the item is tar gzipped then extract */ - if(stristr($config['aliases']['alias'][$x]['aliasurl'], ".tgz")) + if(stristr($alias['aliasurl'], ".tgz")) process_alias_tgz($temp_filename); - if(stristr($config['aliases']['alias'][$x]['aliasurl'], ".zip")) + else if(stristr($alias['aliasurl'], ".zip")) process_alias_unzip($temp_filename); if(file_exists("{$temp_filename}/aliases")) { $file_contents = file_get_contents("{$temp_filename}/aliases"); @@ -1628,12 +1632,7 @@ function update_alias_url_data() { $isfirst = 1; } } - if($isfirst == 0) { - /* nothing was found */ - $dont_update = true; - break; - } - if(!$dont_update) { + if($isfirst > 0) { $config['aliases']['alias'][$x]['address'] = $address; $updated = true; } |