summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRenato Botelho <renato.botelho@bluepex.com>2010-04-12 10:42:31 -0300
committerRenato Botelho <renato.botelho@bluepex.com>2010-04-12 10:42:31 -0300
commitb52d3aa509a54854a0fccd7685f4db12ad5fc15f (patch)
tree54705f44eafe1265cf17ebcfaa5e9ca978280680
parentdb39842bbbe65c698c7fa8fbea0f7dd9c56dd5c9 (diff)
downloadpfsense-b52d3aa509a54854a0fccd7685f4db12ad5fc15f.zip
pfsense-b52d3aa509a54854a0fccd7685f4db12ad5fc15f.tar.gz
When renaming or removing aliases, deal with new NAT Port Forwarding fields
-rwxr-xr-xusr/local/www/firewall_aliases.php16
-rwxr-xr-xusr/local/www/firewall_aliases_edit.php5
2 files changed, 17 insertions, 4 deletions
diff --git a/usr/local/www/firewall_aliases.php b/usr/local/www/firewall_aliases.php
index 1598c9f..842447e 100755
--- a/usr/local/www/firewall_aliases.php
+++ b/usr/local/www/firewall_aliases.php
@@ -113,17 +113,27 @@ if ($_GET['act'] == "del") {
if($is_alias_referenced == false) {
if(is_array($config['nat']['rule'])) {
foreach($config['nat']['rule'] as $rule) {
- if($rule['target'] == $alias_name) {
+ if($rule['source']['address'] == $alias_name) {
+ $is_alias_referenced = true;
+ $referenced_by = $rule['descr'];
+ break;
+ }
+ if($rule['source']['port'] == $alias_name) {
$is_alias_referenced = true;
$referenced_by = $rule['descr'];
break;
}
- if($rule['external-address'] == $alias_name) {
+ if($rule['destination']['address'] == $alias_name) {
$is_alias_referenced = true;
$referenced_by = $rule['descr'];
break;
}
- if($rule['external-port'] == $alias_name) {
+ if($rule['destination']['port'] == $alias_name) {
+ $is_alias_referenced = true;
+ $referenced_by = $rule['descr'];
+ break;
+ }
+ if($rule['target'] == $alias_name) {
$is_alias_referenced = true;
$referenced_by = $rule['descr'];
break;
diff --git a/usr/local/www/firewall_aliases_edit.php b/usr/local/www/firewall_aliases_edit.php
index 598e162..695717f 100755
--- a/usr/local/www/firewall_aliases_edit.php
+++ b/usr/local/www/firewall_aliases_edit.php
@@ -268,8 +268,11 @@ if ($_POST) {
update_alias_names_upon_change('filter', 'rule', 'source', 'address', $_POST['name'], $origname);
update_alias_names_upon_change('filter', 'rule', 'destination', 'address', $_POST['name'], $origname);
// NAT Rules
+ update_alias_names_upon_change('nat', 'rule', 'source', 'address', $_POST['name'], $origname);
+ update_alias_names_upon_change('nat', 'rule', 'source', 'port', $_POST['name'], $origname);
+ update_alias_names_upon_change('nat', 'rule', 'destination', 'address', $_POST['name'], $origname);
+ update_alias_names_upon_change('nat', 'rule', 'destination', 'port', $_POST['name'], $origname);
update_alias_names_upon_change('nat', 'rule', 'target', '', $_POST['name'], $origname);
- update_alias_names_upon_change('nat', 'rule', 'external-port', '', $_POST['name'], $origname);
update_alias_names_upon_change('nat', 'rule', 'local-port', '' , $_POST['name'], $origname);
// Alias in an alias
update_alias_names_upon_change('aliases', 'alias', 'address', '' , $_POST['name'], $origname);
OpenPOWER on IntegriCloud