summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNOYB <Al_Stu@Frontier.com>2017-01-16 13:50:53 -0800
committerNOYB <Al_Stu@Frontier.com>2017-01-17 14:18:35 -0800
commit873a236bfe372aa4df726929afa932e989a0898f (patch)
tree0a778501890cfb5b8dda52fe81e83fc48f6c99f3
parent66fb0bbeec5303ec2ef47a95a5af06c5605472d6 (diff)
downloadpfsense-873a236bfe372aa4df726929afa932e989a0898f.zip
pfsense-873a236bfe372aa4df726929afa932e989a0898f.tar.gz
Status / Interfaces - Match Var Names
Match Form Input and Function Parameter Names with associated Var Name. Use "ifdescr" as form input name instead of "if" since "ifsescr" is the var being passed. Use "ifdescr" as showDefBtn function var instead of "ifval" since "ifsescr" is the var being passed. Avoid confusion with $info['if'].
-rw-r--r--src/usr/local/www/status_interfaces.php10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/usr/local/www/status_interfaces.php b/src/usr/local/www/status_interfaces.php
index 3b49995..ae589b9 100644
--- a/src/usr/local/www/status_interfaces.php
+++ b/src/usr/local/www/status_interfaces.php
@@ -66,8 +66,8 @@ require_once("guiconfig.inc");
require_once("shaper.inc");
require_once("filter.inc");
-if ($_POST['if'] && $_POST['submit']) {
- $interface = $_POST['if'];
+if ($_POST['ifdescr'] && $_POST['submit']) {
+ $interface = $_POST['ifdescr'];
if ($_POST['status'] == "up") {
interface_bring_down($interface);
} else {
@@ -78,7 +78,7 @@ if ($_POST['if'] && $_POST['submit']) {
}
$formtemplate = '<form name="%s" action="status_interfaces.php" method="post">' .
- '<input type="hidden" name="if" value="%s" />' .
+ '<input type="hidden" name="ifdescr" value="%s" />' .
'<input type="hidden" name="status" value="%s" />' .
'%s' .
'<button type="submit" name="submit" class="btn btn-warning btn-xs" value="%s">' .
@@ -96,13 +96,13 @@ function showDef($show, $term, $def) {
}
// Display a term/definition pair with a button
-function showDefBtn($show, $term, $def, $ifval, $btnlbl) {
+function showDefBtn($show, $term, $def, $ifdescr, $btnlbl) {
global $formtemplate;
if ($show) {
print('<dt>' . $term . '</dt>');
print('<dd>');
- printf($formtemplate, $term, $ifval, $show, htmlspecialchars($def) . ' ', $btnlbl, $btnlbl);
+ printf($formtemplate, $term, $ifdescr, $show, htmlspecialchars($def) . ' ', $btnlbl, $btnlbl);
print('</dd>');
}
}
OpenPOWER on IntegriCloud