diff options
author | Phil Davis <phil.davis@inf.org> | 2015-12-17 08:27:38 +0545 |
---|---|---|
committer | Phil Davis <phil.davis@inf.org> | 2015-12-17 08:27:38 +0545 |
commit | 03b01d4ff0c38fb90ddf721e558307d71ff10e51 (patch) | |
tree | 230bfbff915b4a7a8ff194a843b9a3c7241cde94 | |
parent | 9851ce32c1c40281fd76ac1ff140acaccbcc1d30 (diff) | |
download | pfsense-03b01d4ff0c38fb90ddf721e558307d71ff10e51.zip pfsense-03b01d4ff0c38fb90ddf721e558307d71ff10e51.tar.gz |
services_pppoe_edit handle both GET and POST
This wacky logic would only have got to the $_POST checks if $_GET['id'] was already set.
I haven't looked to analyse it - but how would anything using $_POST have worked?
-rw-r--r-- | src/usr/local/www/services_pppoe_edit.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/usr/local/www/services_pppoe_edit.php b/src/usr/local/www/services_pppoe_edit.php index f358749..6da30c6 100644 --- a/src/usr/local/www/services_pppoe_edit.php +++ b/src/usr/local/www/services_pppoe_edit.php @@ -88,8 +88,8 @@ $a_pppoes = &$config['pppoes']['pppoe']; if (is_numericint($_GET['id'])) { $id = $_GET['id']; - -if (isset($_POST['id']) && is_numericint($_POST['id'])) +} +if (isset($_POST['id']) && is_numericint($_POST['id'])) { $id = $_POST['id']; } |