diff options
| author | Scott Ullrich <sullrich@pfsense.org> | 2005-01-12 03:33:41 +0000 |
|---|---|---|
| committer | Scott Ullrich <sullrich@pfsense.org> | 2005-01-12 03:33:41 +0000 |
| commit | b56f04bee533fedcad6d60be7e6debe7adc657e1 (patch) | |
| tree | e5ee9e0b7601416b8847238c03a73499ea00ea86 | |
| parent | 1cd160578cdcb106a8a16cc23462460633933710 (diff) | |
| download | pfsense-b56f04bee533fedcad6d60be7e6debe7adc657e1.zip pfsense-b56f04bee533fedcad6d60be7e6debe7adc657e1.tar.gz | |
Check isset values to make sure they have a value before using.
| -rw-r--r-- | etc/inc/filter.inc | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/etc/inc/filter.inc b/etc/inc/filter.inc index b502af9..d875e12 100644 --- a/etc/inc/filter.inc +++ b/etc/inc/filter.inc @@ -816,7 +816,7 @@ EOD; $line = $type; } - if(!isset($rule['direction'])) { + if(!isset($rule['direction']) and $rule['direction'] <> "") { $line .= " in "; } else { $line .= " " . $rule['direction'] . " "; @@ -977,13 +977,15 @@ EOD; } } - if( isset($rule['source-track']) or isset($rule['max-src-nodes']) or isset($rule['max-src-states'] ) ) { + if( isset($rule['source-track']) and $rule['source-track'] <> "" or + isset($rule['max-src-nodes']) and $rule['max-src-nodes'] <> "" or + isset($rule['max-src-states']) and $rule['max-src-states'] <> "" ) { $line .= "( "; - if(isset($rule['source-track'])) + if(isset($rule['source-track']) & $rule['source-track'] <> "") $line .= "source-track rule "; - if(isset($rule['max-src-nodes'])) - $line .= "max-src-nodes " . $rule['max-src-nodes'] . " "; - if(isset($rule['max-src-states'])) + if(isset($rule['max-src-nodes']) & $rule['max-src-nodes'] <> "") + $line .= "max-src-nodes " . $rule['max-src-nodes'] . ""; + if(isset($rule['max-src-states']) & $rule['max-src-states'] <> "") $line .= "max-src-states" . $rule['max-src-states'] . " "; $line .= " ) "; } |
