summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Buechler <cmb@pfsense.org>2015-04-04 00:06:02 -0500
committerChris Buechler <cmb@pfsense.org>2015-04-04 00:06:02 -0500
commit7dff06c41dba6620c9b50f2fb14f1837780ac3f0 (patch)
tree55a5f767cee27dfdddac40082f0c71da60abf472
parent6986b70344b37e855f86e7883c7ee855cd440e7d (diff)
downloadpfsense-7dff06c41dba6620c9b50f2fb14f1837780ac3f0.zip
pfsense-7dff06c41dba6620c9b50f2fb14f1837780ac3f0.tar.gz
There is no longer any need to restrict protocols for IPv4+IPv6 rules, the appropriate ruleset is generated and problem scenarios that would otherwise break here are prevented by other input validation.
-rw-r--r--usr/local/www/firewall_rules_edit.php5
1 files changed, 0 insertions, 5 deletions
diff --git a/usr/local/www/firewall_rules_edit.php b/usr/local/www/firewall_rules_edit.php
index 1e438c1..5deeabf 100644
--- a/usr/local/www/firewall_rules_edit.php
+++ b/usr/local/www/firewall_rules_edit.php
@@ -298,11 +298,6 @@ if ($_POST) {
$input_errors[] = gettext("You can not assign an IPv6 Gateway to an IPv4 Filter rule");
}
}
-
- if (($_POST['proto'] != "tcp") && ($_POST['proto'] != "udp") && ($_POST['proto'] != "tcp/udp") && ($_POST['proto'] != "icmp")) {
- if($_POST['ipprotocol'] == "inet46")
- $input_errors[] = gettext("You can not assign a protocol other than ICMP, TCP, UDP or TCP/UDP to a rule that applies to IPv4 and IPv6");
- }
if (($_POST['proto'] == "icmp") && ($_POST['icmptype'] <> "")){
if($_POST['ipprotocol'] == "inet46")
$input_errors[] = gettext("You can not assign a ICMP type to a rule that applies to IPv4 and IPv6");
OpenPOWER on IntegriCloud