diff options
author | Ermal <eri@pfsense.org> | 2011-06-06 13:12:55 +0000 |
---|---|---|
committer | Ermal <eri@pfsense.org> | 2011-06-06 13:12:55 +0000 |
commit | 7d6be855ce80a6dcf0cd984f14386aae1b876edb (patch) | |
tree | 13d790c6e7616272cc1f21a17c55e1c807e66990 | |
parent | ac07425a65b3590c1f391c96b31406ae4942064d (diff) | |
download | pfsense-7d6be855ce80a6dcf0cd984f14386aae1b876edb.zip pfsense-7d6be855ce80a6dcf0cd984f14386aae1b876edb.tar.gz |
Correct possible lock leak.
-rw-r--r-- | etc/inc/captiveportal.inc | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/etc/inc/captiveportal.inc b/etc/inc/captiveportal.inc index 1d4356f..609bfed 100644 --- a/etc/inc/captiveportal.inc +++ b/etc/inc/captiveportal.inc @@ -826,18 +826,15 @@ function captiveportal_disconnect_client($sessionid, $term_cause = 1, $logoutRea $radiusservers = captiveportal_get_radius_servers(); $unsetindex = array(); - $cpdblck = lock('captiveportaldb', LOCK_EX); - /* read database */ - $cpdb = captiveportal_read_db(true); + $cpdb = captiveportal_read_db(); /* find entry */ if (isset($cpdb[$sessionid])) { $cpentry = $cpdb[$sessionid]; /* write database */ $unsetindex[] = $sessionid; - captiveportal_write_db($cpdb, true, $unsetindex); - unlock($cpdblck); + captiveportal_write_db($cpdb, false, $unsetindex); captiveportal_disconnect($cpentry, $radiusservers, $term_cause); captiveportal_logportalauth($cpentry[4], $cpentry[3], $cpentry[2], "DISCONNECT"); |