summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjim-p <jimp@pfsense.org>2011-03-04 08:06:31 -0500
committerjim-p <jimp@pfsense.org>2011-03-04 08:09:41 -0500
commit1b761f36b7c2c484f894e6412a1efad769533696 (patch)
treeec86313b024b496656749731024f4e198aac25c9
parent1c1a74fa78a25932e391a15eb9ee7c4253320da9 (diff)
downloadpfsense-1b761f36b7c2c484f894e6412a1efad769533696.zip
pfsense-1b761f36b7c2c484f894e6412a1efad769533696.tar.gz
Check if the protocol is empty, not just if it's set. Fixes #1323
-rw-r--r--etc/inc/filter.inc2
1 files changed, 1 insertions, 1 deletions
diff --git a/etc/inc/filter.inc b/etc/inc/filter.inc
index 20946dc..18428fc 100644
--- a/etc/inc/filter.inc
+++ b/etc/inc/filter.inc
@@ -1760,7 +1760,7 @@ function filter_generate_user_rule($rule) {
log_error("The gateway: {$rule['gateway']} is invalid or unknown, not using it.");
}
- if(isset($rule['protocol'])) {
+ if (isset($rule['protocol']) && !empty($rule['protocol'])) {
if($rule['protocol'] == "tcp/udp")
$aline['prot'] = " proto { tcp udp } ";
elseif($rule['protocol'] == "icmp")
OpenPOWER on IntegriCloud