diff options
| author | jim-p <jimp@pfsense.org> | 2014-08-08 10:23:14 -0400 |
|---|---|---|
| committer | jim-p <jimp@pfsense.org> | 2014-08-08 10:26:36 -0400 |
| commit | 8108b4235b35dc1e21951d5754e6ea4f190e079f (patch) | |
| tree | 567e0ed4c94b2a9e699b40191d7df64cd7d2464f | |
| parent | a9d6ac9aac9d3ba6d4e9bc0a92b0f813b2e0e7e7 (diff) | |
| download | pfsense-8108b4235b35dc1e21951d5754e6ea4f190e079f.zip pfsense-8108b4235b35dc1e21951d5754e6ea4f190e079f.tar.gz | |
Remove javascript alert DNS resolution action from the firewall log view. It was already removed from 2.2, and it's better not to allow a GET action to perform that action.
| -rw-r--r-- | usr/local/www/diag_dns.php | 5 | ||||
| -rwxr-xr-x | usr/local/www/diag_logs_filter.php | 4 |
2 files changed, 0 insertions, 9 deletions
diff --git a/usr/local/www/diag_dns.php b/usr/local/www/diag_dns.php index 3b0bd40..6b15944 100644 --- a/usr/local/www/diag_dns.php +++ b/usr/local/www/diag_dns.php @@ -140,11 +140,6 @@ if ($_POST) { } } -if( ($_POST['host']) && ($_POST['dialog_output']) ) { - display_host_results ($host,$resolved,$dns_speeds); - exit; -} - function display_host_results ($address,$hostname,$dns_speeds) { $map_lengths = function($element) { return strlen($element[0]); }; diff --git a/usr/local/www/diag_logs_filter.php b/usr/local/www/diag_logs_filter.php index a212f5c..b6e1bf0 100755 --- a/usr/local/www/diag_logs_filter.php +++ b/usr/local/www/diag_logs_filter.php @@ -361,8 +361,6 @@ include("head.inc"); $dststr = $filterent['dstip'] . get_port_with_service($filterent['dstport'], $proto); ?> <td class="listMRr" nowrap="nowrap"> - <a onclick="javascript:getURL('diag_dns.php?host=<?php echo "{$filterent['srcip']}"; ?>&dialog_output=true', outputrule);" title="<?=gettext("Reverse Resolve with DNS");?>"> - <img border="0" src="/themes/<?= $g['theme']; ?>/images/icons/icon_log_d.gif" alt="Icon Reverse Resolve with DNS"/></a> <a href="diag_dns.php?host=<?php echo $filterent['srcip']; ?>" title="<?=gettext("Reverse Resolve with DNS");?>"> <img border="0" src="/themes/<?= $g['theme']; ?>/images/icons/icon_log.gif" alt="Icon Reverse Resolve with DNS"/></a> <a href="easyrule.php?<?php echo "action=block&int={$int}&src={$filterent['srcip']}&ipproto={$ipproto}"; ?>" title="<?=gettext("Easy Rule: Add to Block List");?>" onclick="return confirm('<?=gettext("Do you really want to add this BLOCK rule?")."\n\n".gettext("Easy Rule is still experimental.")."\n".gettext("Continue at risk of your own peril.")."\n".gettext("Backups are also nice.")?>')"> @@ -370,8 +368,6 @@ include("head.inc"); <?php echo $srcstr;?> </td> <td class="listMRr" nowrap="nowrap"> - <a onclick="javascript:getURL('diag_dns.php?host=<?php echo "{$filterent['dstip']}"; ?>&dialog_output=true', outputrule);" title="<?=gettext("Reverse Resolve with DNS");?>"> - <img border="0" src="/themes/<?= $g['theme']; ?>/images/icons/icon_log_d.gif" alt="Icon Reverse Resolve with DNS" /></a> <a href="diag_dns.php?host=<?php echo $filterent['dstip']; ?>" title="<?=gettext("Reverse Resolve with DNS");?>"> <img border="0" src="/themes/<?= $g['theme']; ?>/images/icons/icon_log.gif" alt="Icon Reverse Resolve with DNS" /></a> <a href="easyrule.php?<?php echo "action=pass&int={$int}&proto={$proto}&src={$filterent['srcip']}&dst={$filterent['dstip']}&dstport={$filterent['dstport']}&ipproto={$ipproto}"; ?>" title="<?=gettext("Easy Rule: Pass this traffic");?>" onclick="return confirm('<?=gettext("Do you really want to add this PASS rule?")."\n\n".gettext("Easy Rule is still experimental.")."\n".gettext("Continue at risk of your own peril.")."\n".gettext("Backups are also nice.");?>')"> |
