diff options
| author | Renato Botelho <garga@FreeBSD.org> | 2014-06-17 09:40:06 -0300 |
|---|---|---|
| committer | Renato Botelho <garga@FreeBSD.org> | 2014-06-17 09:40:06 -0300 |
| commit | e41ab9aa320b4e64a8b99271bb7d3d094da59d56 (patch) | |
| tree | 698dd841812af499c2159f8df5d4cf3083b555d4 | |
| parent | ee4ba9fba1f9d49396f3a4882a3239a83c5036d6 (diff) | |
| download | pfsense-e41ab9aa320b4e64a8b99271bb7d3d094da59d56.zip pfsense-e41ab9aa320b4e64a8b99271bb7d3d094da59d56.tar.gz | |
Escape parameters passed to shell_exec()
| -rw-r--r-- | usr/local/pkg/openntpd.inc | 2 | ||||
| -rw-r--r-- | usr/local/www/diag_smart.php | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/usr/local/pkg/openntpd.inc b/usr/local/pkg/openntpd.inc index c4914b8..dcbb50a 100644 --- a/usr/local/pkg/openntpd.inc +++ b/usr/local/pkg/openntpd.inc @@ -21,7 +21,7 @@ EOD; function openntpd_get_iface_ip($iface) { $iface = convert_friendly_interface_to_real_interface_name($iface); - $line = trim(shell_exec("ifconfig $iface | grep inet | grep -v inet6")); + $line = trim(shell_exec("ifconfig " . escapeshellarg($iface) . " | grep inet | grep -v inet6")); list($dummy, $ip, $dummy2, $dummy3) = explode(' ', $line); return $ip; diff --git a/usr/local/www/diag_smart.php b/usr/local/www/diag_smart.php index d2309e6..73f3405 100644 --- a/usr/local/www/diag_smart.php +++ b/usr/local/www/diag_smart.php @@ -85,7 +85,7 @@ function update_email($email) if(!empty($email)) { // Put it in the smartd.conf file - shell_exec("/usr/bin/sed -i old 's/^DEVICESCAN.*/DEVICESCAN -H -m " . $email . "/' /usr/local/etc/smartd.conf"); + shell_exec("/usr/bin/sed -i old 's/^DEVICESCAN.*/DEVICESCAN -H -m " . escapeshellarg($email) . "/' /usr/local/etc/smartd.conf"); } // Nope else |
