summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorErmal Luçi <eri@pfsense.org>2008-07-20 20:45:17 +0000
committerErmal Luçi <eri@pfsense.org>2008-07-20 20:45:17 +0000
commitfdcaa5272e5b7a46c72f3c06dc46980cd1295dc7 (patch)
tree5903ecfd48f10e3b597bdda8e95dbfc477370447
parent789af3637a585bdd5eaeb74d7c8855746c54c1fd (diff)
downloadpfsense-fdcaa5272e5b7a46c72f3c06dc46980cd1295dc7.zip
pfsense-fdcaa5272e5b7a46c72f3c06dc46980cd1295dc7.tar.gz
Fix NO-IP dyndns client the url has changed according to the source code of the client distributed by no-ip.com and from my test. Use urlencode() for usernames when passed directly on url.
-rw-r--r--etc/inc/dyndns.class8
1 files changed, 4 insertions, 4 deletions
diff --git a/etc/inc/dyndns.class b/etc/inc/dyndns.class
index efccb58..fc3441c 100644
--- a/etc/inc/dyndns.class
+++ b/etc/inc/dyndns.class
@@ -34,9 +34,9 @@
* DynDNS Dynamic - Last Tested: 12 July 2005
* DynDNS Static - Last Tested: NEVER
* DynDNS Custom - Last Tested: NEVER
- * No-IP - Last Tested: 12 July 2005
+ * No-IP - Last Tested: 20 July 2008
* HN.org - Last Tested: 12 July 2005
- * EasyDNS - Last Tested: NEVER
+ * EasyDNS - Last Tested: 20 July 2008
* DHS - Last Tested: 12 July 2005
* ZoneEdit - Last Tested: NEVER
* Dyns - Last Tested: NEVER
@@ -255,7 +255,7 @@
$server = $this->_dnsServer;
if($this->_dnsPort)
$port = ":" . $this->_dnsPort;
- curl_setopt($ch, CURLOPT_URL, $server . $port . '?username=' . $this->_dnsUser . '&password=' . $this->_dnsPass . '&hostname=' . $this->_dnsHost.'&ip=' . $this->_dnsIP);
+ curl_setopt($ch, CURLOPT_URL, $server . $port . '?username=' . urlencode($this->_dnsUser) . '&pass=' . urlencode($this->_dnsPass) . '&hostname=' . $this->_dnsHost.'&ip=' . $this->_dnsIP);
$data = curl_exec($ch);
if (@curl_error($ch)) log_error("Curl errror occured: " . curl_error($ch));
curl_close($ch);
@@ -320,7 +320,7 @@
$server = $this->_dnsServer;
if($this->_dnsPort)
$port = ":" . $this->_dnsPort;
- curl_setopt($ch, CURLOPT_URL, $server . $port . '?username=' . $this->_dnsUser . '&password=' . $this->_dnsPass . '&host=' . $this->_dnsHost);
+ curl_setopt($ch, CURLOPT_URL, $server . $port . '?username=' . urlencode($this->_dnsUser) . '&password=' . $this->_dnsPass . '&host=' . $this->_dnsHost);
$data = curl_exec($ch);
if (@curl_error($ch)) log_error("Curl errror occured: " . curl_error($ch));
curl_close($ch);
OpenPOWER on IntegriCloud