summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorErmal <eri@pfsense.org>2013-01-26 16:37:33 +0000
committerErmal <eri@pfsense.org>2013-01-26 16:37:33 +0000
commiteaf87cb0f96c083e0586617699d8e4095e04e468 (patch)
treef51af1f485b30af504a5fd5e447ab4fc64529c13
parenta216db0faf0e8b9e5104862984c9c71388e558ac (diff)
downloadpfsense-eaf87cb0f96c083e0586617699d8e4095e04e468.zip
pfsense-eaf87cb0f96c083e0586617699d8e4095e04e468.tar.gz
No need for escaping here since this is php internal functions
-rw-r--r--etc/inc/interfaces.inc13
1 files changed, 6 insertions, 7 deletions
diff --git a/etc/inc/interfaces.inc b/etc/inc/interfaces.inc
index db98863..27f1158 100644
--- a/etc/inc/interfaces.inc
+++ b/etc/inc/interfaces.inc
@@ -495,19 +495,18 @@ function interface_bridge_configure(&$bridge, $checkmember = 0) {
/* Add interfaces to bridge */
foreach ($members as $member) {
- if (!array_key_exists($member, $checklist))
+ if (empty($checklist[$member]))
continue;
- $realif1 = get_real_interface($member);
- $realif = escapeshellarg($realif1);
+ $realif = get_real_interface($member);
if (!$realif) {
log_error("realif not defined in interfaces bridge - up");
continue;
}
/* make sure the parent interface is up */
- pfSense_interface_mtu($realif1, $smallermtu);
- pfSense_interface_capabilities($realif1, -$flags);
- interfaces_bring_up($realif1);
- pfSense_bridge_add_member($bridgeif, $realif1);
+ pfSense_interface_mtu($realif, $smallermtu);
+ pfSense_interface_capabilities($realif, -$flags);
+ interfaces_bring_up($realif);
+ pfSense_bridge_add_member($bridgeif, $realif);
}
if (isset($bridge['enablestp'])) {
OpenPOWER on IntegriCloud