summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjim-p <jimp@pfsense.org>2012-08-01 14:45:41 -0400
committerjim-p <jimp@pfsense.org>2012-08-01 14:55:04 -0400
commite97c2778ff750896f65bebe3d09de6d7479f8b7e (patch)
tree2a4e003c9184498cfb0a3446f075ac70d25a9469
parent3163c3aa3b186050307fc2e8916169b20b055240 (diff)
downloadpfsense-e97c2778ff750896f65bebe3d09de6d7479f8b7e.zip
pfsense-e97c2778ff750896f65bebe3d09de6d7479f8b7e.tar.gz
Protect against a potential infinite loop here.
-rwxr-xr-xusr/local/www/firewall_nat_out.php3
1 files changed, 2 insertions, 1 deletions
diff --git a/usr/local/www/firewall_nat_out.php b/usr/local/www/firewall_nat_out.php
index 07a492e..a254bc7 100755
--- a/usr/local/www/firewall_nat_out.php
+++ b/usr/local/www/firewall_nat_out.php
@@ -138,7 +138,8 @@ if (isset($_POST['save']) && $_POST['save'] == "Save") {
/* PPTP subnet */
if (($config['pptpd']['mode'] == "server") && is_private_ip($config['pptpd']['remoteip'])) {
- $pptptopip = $config['pptpd']['n_pptp_units'] - 1;
+ $pptp_size = empty($config['pptpd']['n_pptp_units']) ? 16 : $config['pptpd']['n_pptp_units'];
+ $pptptopip = $pptp_size - 1;
$pptp_subnets = ip_range_to_subnet_array($config['pptpd']['remoteip'], long2ip32(ip2long($config['pptpd']['remoteip'])+$pptptopip));
foreach ($pptp_subnets as $pptpsn) {
$natent = array();
OpenPOWER on IntegriCloud