diff options
author | Ermal <eri@pfsense.org> | 2010-09-01 16:42:47 +0000 |
---|---|---|
committer | Ermal <eri@pfsense.org> | 2010-09-01 16:42:47 +0000 |
commit | 064e18072d28f6e393db409c71bb7c9c1a086c5f (patch) | |
tree | 039df286695afbd10c57c77f18c2f42d0b8f4e77 | |
parent | 680714775fb3485cd1613815cbcf097911bfbf6c (diff) | |
download | pfsense-064e18072d28f6e393db409c71bb7c9c1a086c5f.zip pfsense-064e18072d28f6e393db409c71bb7c9c1a086c5f.tar.gz |
And some safe belts to prevent wrong lines in inetd.conf
-rw-r--r-- | etc/inc/filter.inc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/etc/inc/filter.inc b/etc/inc/filter.inc index 7d6b8fb..819a54f 100644 --- a/etc/inc/filter.inc +++ b/etc/inc/filter.inc @@ -969,7 +969,7 @@ function filter_generate_reflection($rule, $nordr, $rdr_ifs, $srcaddr, $dstaddr_ $rflctnorange = true; if(is_alias($loc_pt)) { $loc_pt_translated = filter_expand_alias($loc_pt); - if(!$loc_pt_translated) { + if(empty($loc_pt_translated)) { log_error("Reflection processing: {$loc_pt} is not a vaild port alias."); continue; } @@ -1003,7 +1003,9 @@ function filter_generate_reflection($rule, $nordr, $rdr_ifs, $srcaddr, $dstaddr_ $starting_localhost_port++; } - foreach($toadd_array as $tda){ + foreach($toadd_array as $tda) { + if (empty($tda)) + continue; foreach($reflect_protos as $reflect_proto) { if($reflect_proto == "udp") { $socktype = "dgram"; |