From 0dca060c2a5a83dc8bd28eb2d8b559bd33238175 Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Thu, 2 Nov 2017 12:48:11 -0700 Subject: xfs: scrub: avoid uninitialized return code The newly added xfs_scrub_da_btree_block() function has one code path that returns the 'error' variable without initializing it first, as shown by this compiler warning: fs/xfs/scrub/dabtree.c: In function 'xfs_scrub_da_btree_block': fs/xfs/scrub/dabtree.c:462:9: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized] Return zero since the caller will exit the scrub code if we don't produce a buffer pointer. Fixes: 7c4a07a424c1 ("xfs: scrub directory/attribute btrees") Reported-by: Arnd Bergmann Signed-off-by: Darrick J. Wong Reviewed-by: Brian Foster --- fs/xfs/scrub/dabtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fs/xfs/scrub') diff --git a/fs/xfs/scrub/dabtree.c b/fs/xfs/scrub/dabtree.c index c21c528..4c9839c 100644 --- a/fs/xfs/scrub/dabtree.c +++ b/fs/xfs/scrub/dabtree.c @@ -336,7 +336,7 @@ xfs_scrub_da_btree_block( xfs_ino_t owner; int *pmaxrecs; struct xfs_da3_icnode_hdr nodehdr; - int error; + int error = 0; blk = &ds->state->path.blk[level]; ds->state->path.active = level + 1; -- cgit v1.1